Skip to content

[Monitor]Fix monitor output table tsv#995

Merged
zikalino merged 6 commits intoAzure:masterfrom
mmyyrroonn:fix-monitor-output-table-tsv
Nov 4, 2019
Merged

[Monitor]Fix monitor output table tsv#995
zikalino merged 6 commits intoAzure:masterfrom
mmyyrroonn:fix-monitor-output-table-tsv

Conversation

@mmyyrroonn
Copy link
Copy Markdown
Contributor

@mmyyrroonn mmyyrroonn commented Oct 12, 2019 •
edited
Loading

Fix #936
This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

@azuresdkci
Copy link
Copy Markdown

azuresdkci commented Oct 12, 2019

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:

docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/MyronFanQiu/azure-cli-extensions.git@fix-monitor-output-table-tsv#subdirectory=src/$EXT&egg=$EXT"

@mmyyrroonn mmyyrroonn requested a review from alexeldeib October 12, 2019 03:24
@yonzhan yonzhan requested review from Juliehzl and zikalino October 13, 2019 05:14
@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Oct 13, 2019

@myronfanqiu please take a look.

@zikalino
Copy link
Copy Markdown

zikalino commented Oct 14, 2019

@myronfanqiu Please fix this and it will be good to merge:

C: 25,12: Consider using enumerate instead of iterating with range and len (consider-using-enumerate)

@alexeldeib
Copy link
Copy Markdown
Contributor

alexeldeib commented Oct 24, 2019

@myronfanqiu thanks for the work, will be happy to get this in 🙂

@mmyyrroonn mmyyrroonn force-pushed the fix-monitor-output-table-tsv branch from 6ec9a44 to b09de88 Compare November 4, 2019 02:34
@mmyyrroonn mmyyrroonn force-pushed the fix-monitor-output-table-tsv branch from ad2b497 to 22477fc Compare November 4, 2019 05:49
@zikalino zikalino merged commit 024ff56 into Azure:master Nov 4, 2019
ManuInNZ pushed a commit to ManuInNZ/azure-cli-extensions that referenced this pull request Apr 11, 2020
@mmyyrroonn @ManuInNZ
[Monitor]Fix monitor output table tsv (Azure#995)
e9a74b9 
* fix table and tsv

* fix tsv and format

* fix

* fix format

* fix style

* update index
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexeldeib alexeldeib Awaiting requested review from alexeldeib

@Juliehzl Juliehzl Awaiting requested review from Juliehzl

1 more reviewer

@zikalino zikalino zikalino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mmyyrroonn mmyyrroonn

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

tsv and table outputs won't work with az monitor log-analytics query

5 participants

@mmyyrroonn @azuresdkci @yonzhan @zikalino @alexeldeib