Conversation
718be23 to
77684ee
Compare
update peering changed delete implementation rebuild index fixed error header add codeowner sanity history + unused antlr4 unused imports live tests updated delete fix test updated test resource group regenerated examples - first attempt fix in actions fix prefix create error fix for prefix fixed broken import required parameters for peering service regenerated peering regenerated peering actions prefixe -> prefix unnecessary imports are removed no args --> pass updated peering with read-only stuff some things updated in the generator level removed incomplete example added direct peer asn additional fix fixed phone and e-mails in peering fixed mistake final formatting another help formatting help update 2 updated peering help another peering action update manual fix fix dump entire option string additional stuff manually adding action handling new version fixed operations imports comment out just in case another fix peerings renamed prefix peering service prefix properly generated generated peering_service replaced api version missing create peering asn code flattened peer contact info no parameters params fixes fixed help mistakes one more fix several naming fixes to backpropagate to generator fixed paths added vendored sdk adding first version of peering
mmyyrroonn
approved these changes
Oct 28, 2019
ManuInNZ
pushed a commit
to ManuInNZ/azure-cli-extensions
that referenced
this pull request
Apr 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions: