Skip to content

vm-repair: hotfix for None replacement error for all linux VMs#970

Merged
yonzhan merged 1 commit intoAzure:masterfrom
swbae31:linux_username_hotfix
Sep 27, 2019
Merged

vm-repair: hotfix for None replacement error for all linux VMs#970
yonzhan merged 1 commit intoAzure:masterfrom
swbae31:linux_username_hotfix

Conversation

@swbae31
Copy link
Copy Markdown
Contributor

@swbae31 swbae31 commented Sep 27, 2019

This is a urgent hotfix for an error that is happening for all Linux VMs.

One line check has been added for null usernames.

Clear to merge when reviewed.

@swbae31 swbae31 requested a review from zikalino as a code owner September 27, 2019 21:27
@azuresdkci
Copy link
Copy Markdown

azuresdkci commented Sep 27, 2019

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:

docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/swbae31/azure-cli-extensions.git@linux_username_hotfix#subdirectory=src/$EXT&egg=$EXT"

@swbae31 swbae31 force-pushed the linux_username_hotfix branch from e1ee5b1 to 0676f5e Compare September 27, 2019 21:31
@yonzhan yonzhan merged commit cbe2828 into Azure:master Sep 27, 2019
ManuInNZ pushed a commit to ManuInNZ/azure-cli-extensions that referenced this pull request Apr 11, 2020
@swbae31 @ManuInNZ
Hot fix for None error when username is Null (Azure#970)
3806588
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yonzhan yonzhan yonzhan approved these changes

@zikalino zikalino Awaiting requested review from zikalino

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@swbae31 @azuresdkci @yonzhan