Skip to content

vm-repair: fix small bugs#966

Merged
zikalino merged 1 commit intoAzure:masterfrom
swbae31:create_fixes
Sep 26, 2019
Merged

vm-repair: fix small bugs#966
zikalino merged 1 commit intoAzure:masterfrom
swbae31:create_fixes

Conversation

@swbae31
Copy link
Copy Markdown
Contributor

@swbae31 swbae31 commented Sep 25, 2019 •
edited
Loading

2 small bug fixes.

  1. Fix bug where disk_sku is None and returns error when source vm is deallocated
  2. Hide vm-user-name for telemetry
  • Clear for merge whenever reviews are done.

@swbae31 swbae31 requested a review from zikalino as a code owner September 25, 2019 23:59
@azuresdkci
Copy link
Copy Markdown

azuresdkci commented Sep 25, 2019

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:

docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/swbae31/azure-cli-extensions.git@create_fixes#subdirectory=src/$EXT&egg=$EXT"

@swbae31
Copy link
Copy Markdown
Contributor Author

swbae31 commented Sep 26, 2019

and this got an build error:
requests.exceptions.ConnectionError: ('Connection aborted.', ConnectionResetError(104, 'Connection reset by peer'))

https://dev.azure.com/azure-sdk/public/_build/results?buildId=117825&view=logs&j=b121d099-c3c0-52ad-95f1-31c1567c9ad4&t=ca40adef-e63f-5fd5-f30e-e39a0bf0e914&l=113

what does this mean? Travis CI build passed though.

@zikalino zikalino merged commit 4d4b4fb into Azure:master Sep 26, 2019
ManuInNZ pushed a commit to ManuInNZ/azure-cli-extensions that referenced this pull request Apr 11, 2020
@swbae31 @ManuInNZ
Fix disk_sku vm dealloced bug and hiding vm-user-name for telemetry (A…
969f73d 
…zure#966)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@zikalino zikalino zikalino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@swbae31 @azuresdkci @zikalino