Add support for low-pri scale sets and node taints#962
Merged
zikalino merged 5 commits intoAzure:masterfrom Sep 27, 2019
Merged
Add support for low-pri scale sets and node taints#962zikalino merged 5 commits intoAzure:masterfrom
zikalino merged 5 commits intoAzure:masterfrom
Conversation
jluk
reviewed
Sep 23, 2019
jluk
reviewed
Sep 23, 2019
jluk
reviewed
Sep 23, 2019
|
@zikalino or @GaneshMSAzure could you give this a review? Lots of goodness in this PR :) |
zikalino
approved these changes
Sep 27, 2019
ManuInNZ
pushed a commit
to ManuInNZ/azure-cli-extensions
that referenced
this pull request
Apr 11, 2020
* Add support for low-pri scale sets and node taints * fixing style errors * fixing descriptions * add node public ip support
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding support for low-pri node pools.
Adding support for initial node taints.
Adding support for node public IP (using the same public-ip-per-vm parameter name as az vmss create)
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions: