Skip to content

Default AKS CLI extension to SLB+VMSS when possible#954

Merged
zikalino merged 1 commit intoAzure:masterfrom
xuto2:SLBVMSSDefault
Sep 18, 2019
Merged

Default AKS CLI extension to SLB+VMSS when possible#954
zikalino merged 1 commit intoAzure:masterfrom
xuto2:SLBVMSSDefault

Conversation

@xuto2
Copy link
Copy Markdown
Contributor

@xuto2 xuto2 commented Sep 16, 2019

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

@xuto2 xuto2 requested a review from zqingqing1 as a code owner September 16, 2019 17:30
@azuresdkci
Copy link
Copy Markdown

azuresdkci commented Sep 16, 2019

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:

docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/xuto2/azure-cli-extensions.git@SLBVMSSDefault#subdirectory=src/$EXT&egg=$EXT"

zqingqing1
zqingqing1 approved these changes Sep 17, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@zqingqing1 zqingqing1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zikalino zikalino merged commit 1440482 into Azure:master Sep 18, 2019
ManuInNZ pushed a commit to ManuInNZ/azure-cli-extensions that referenced this pull request Apr 11, 2020
@ManuInNZ
Default AKS CLI extension to SLB+VMSS when possible (Azure#954)
553bb7c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@zikalino zikalino zikalino approved these changes

@zqingqing1 zqingqing1 zqingqing1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@xuto2 @azuresdkci @zikalino @zqingqing1