add support for ccp only upgrade and default to upgrade all#948
Merged
zikalino merged 2 commits intoAzure:masterfrom Sep 19, 2019
Merged
add support for ccp only upgrade and default to upgrade all#948zikalino merged 2 commits intoAzure:masterfrom
zikalino merged 2 commits intoAzure:masterfrom
Conversation
|
If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR: |
81297d8 to
99e27d5
Compare
gtxistxgao
approved these changes
Sep 13, 2019
xuto2
reviewed
Sep 14, 2019
xuto2
reviewed
Sep 14, 2019
xuto2
approved these changes
Sep 14, 2019
Contributor
|
check https://github.com/Azure/azure-cli/pull/10513/files#diff-fe2d1dd3c9fc1d841b3437f1a9aac146 for main CLI sync |
2c49ccd to
41d7f22
Compare
41d7f22 to
db215de
Compare
|
ok, decided to merge it: --control-plane-only and specifically to avoid displaying prompt. But this can be considered / checked later. |
zikalino
approved these changes
Sep 19, 2019
ManuInNZ
pushed a commit
to ManuInNZ/azure-cli-extensions
that referenced
this pull request
Apr 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the new 0801 api version, we now supports control plane only cluster upgrade. Added the control-plane-only argument for this purpose and change the default to upgrade all (by setting kubernetes version of all agentpool profiles explicitly).
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions: