AKS kollect command implementation#947
Merged
zikalino merged 3 commits intoAzure:masterfrom Sep 19, 2019
Merged
Conversation
|
If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR: |
3b7041d to
1dd18e5
Compare
JunSun17
reviewed
Sep 12, 2019
979daed to
ca99bd8
Compare
Jen7714
reviewed
Sep 13, 2019
Jen7714
reviewed
Sep 13, 2019
Jen7714
reviewed
Sep 13, 2019
ad80cf7 to
30a6b34
Compare
30a6b34 to
268b205
Compare
JunSun17
reviewed
Sep 16, 2019
Contributor
JunSun17
left a comment
There was a problem hiding this comment.
Looks good to me, some minor comments inline.
JunSun17
approved these changes
Sep 16, 2019
268b205 to
2d78071
Compare
zikalino
reviewed
Sep 18, 2019
zikalino
reviewed
Sep 18, 2019
zikalino
reviewed
Sep 18, 2019
zikalino
reviewed
Sep 18, 2019
zikalino
reviewed
Sep 18, 2019
zikalino
suggested changes
Sep 18, 2019
zikalino
left a comment
There was a problem hiding this comment.
i think storage_account params should be improved
2d78071 to
5fb8f53
Compare
Contributor
Author
Fixed. Now there is only one storage account parameter and it accepts both Id and name. |
5fb8f53 to
e27985e
Compare
zikalino
approved these changes
Sep 19, 2019
ManuInNZ
pushed a commit
to ManuInNZ/azure-cli-extensions
that referenced
this pull request
Apr 11, 2020
* aks diag command implementation * fixing comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial implementation of the
az aks kollectcommand. This command will deploy a daemon set to customer 's aks cluster and collect logs and diag information. The logs and information will be saved to a storage account the user specified or the storage account specified in the diag settings of the cluster.This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions: