Skip to content

Cross-Tenant virtual network linking for private zones#946

Merged
zikalino merged 3 commits intoAzure:masterfrom
djr-jsr:cross-tenant
Sep 19, 2019
Merged

Cross-Tenant virtual network linking for private zones#946
zikalino merged 3 commits intoAzure:masterfrom
djr-jsr:cross-tenant

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Sep 11, 2019 •
edited by ghost
Loading

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

@ghost ghost requested a review from zikalino as a code owner September 11, 2019 01:27
@azuresdkci
Copy link
Copy Markdown

azuresdkci commented Sep 11, 2019

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:

docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/dijyotir/azure-cli-extensions.git@cross-tenant#subdirectory=src/$EXT&egg=$EXT"

@ghost ghost force-pushed the cross-tenant branch from 85a44b6 to b847e48 Compare September 11, 2019 02:44
@ghost ghost force-pushed the cross-tenant branch from b847e48 to 447b1a9 Compare September 11, 2019 02:55
@zikalino
Copy link
Copy Markdown

zikalino commented Sep 19, 2019

looks good!
sorry for the delay, the pr looked pretty large, but the changes to the ux are minimal, and all the new changes are very well tested. so ready to go.

@zikalino
Copy link
Copy Markdown

zikalino commented Sep 19, 2019

all tests are green, one status not reported for some reason

@zikalino zikalino merged commit 43b4fc8 into Azure:master Sep 19, 2019
@ghost ghost mentioned this pull request Sep 20, 2019
Merged
2 tasks
ManuInNZ pushed a commit to ManuInNZ/azure-cli-extensions that referenced this pull request Apr 11, 2020
@ManuInNZ
Cross-Tenant virtual network linking for private zones (Azure#946)
19937b3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@azuresdkci @zikalino @djr-jsr