Remove hardcoded en-us locale from docs site links.#904
Remove hardcoded en-us locale from docs site links.#904zikalino merged 3 commits intoAzure:masterfrom sptramer:fix-locale-links
Conversation
|
If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR: |
|
@sptramer Hello. Please fix the content in this url. https://azurecliext.blob.core.windows.net/release/azure_cli_ml-1.0.55-py2.py3-none-any.whl |
There was a problem hiding this comment.
I suggest we back out changes under folders of verndored_sdks as those are generated files from swagger specs, and the next round of code-gen will wipe out the change from this PR. If we like to address the root cause, we should update specs.
There was a problem hiding this comment.
@yugangw-msft If everything is generated from the Swagger specs, then this PR should be closed and we can address the root problem (which is the Swagger.) Otherwise feel free to merge it - I've taken an item to look into hardcoded en-us in Swagger.
@myronfanqiu, this extension's source code us hosted at external repository. CC: @gogowings |
|
@yugangw-msft I noticed this hadn't been merged and looked into the error happening on CI. I found that it's actually because the test is expecting It looks like this is because it's comparing the non- I'd like to request that this PR be merged as a result, since I'm not sure of a good way to fix this test. |
|
CC @zikalino owner of CLI extension repository, and @gogowings who owns the ML extension. |
|
If I can get a URL for the ML extension, I can make a similar modification there. But I'm not sure why part of this repository's test infrastructure would be checking something from a different, disconnected repo. |
|
Sorry for the delayed response as I am just back from vacation. As @yugangw-msft mentioned, azure-cli-ml is from an external repo and released separately. We usually release every two weeks and should have a new release this week. We can make the change for this week's CLI release so before end of the week, this will be fixed for the azure-cli-ml's project_urls, and then you can rebase. Sounds like a plan? |
|
@gogowings Sure, that's fine. Ping me in this thread again when that's fixed so I can close and reopen to force a rebuild. |
|
#937 is merged. |
|
@zikalino This should now be ready to merge. Thanks! |
No description provided.