Update DMS extension to new framework; add Oracle to PostgreSQL scenario.#898
Merged
zikalino merged 19 commits intoAzure:masterfrom Sep 19, 2019
vchske:master
Merged
Update DMS extension to new framework; add Oracle to PostgreSQL scenario.#898zikalino merged 19 commits intoAzure:masterfrom vchske:master
zikalino merged 19 commits intoAzure:masterfrom
vchske:master
Conversation
…oDB migrations to force prior validations. - Added mongo to mongo online as a scenario handled by the extension - Minor cleanup - Bumped version to 0.7.1
Getting latest from Azure
Getting latest from Azure
Merging latest from Azure
|
If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR: |
Contributor
Author
|
Can we get an admin to verify this PR? |
zikalino
approved these changes
Sep 19, 2019
zikalino
left a comment
There was a problem hiding this comment.
sorry for some delay, the changes look good to me.
a bit difficult to review due to large vendored_sdks folder.
ManuInNZ
pushed a commit
to ManuInNZ/azure-cli-extensions
that referenced
this pull request
Apr 11, 2020
…ario. (Azure#898) * - Created mandatory argument 'validated taask name' when running MongoDB migrations to force prior validations. - Added mongo to mongo online as a scenario handled by the extension - Minor cleanup - Bumped version to 0.7.1 * Fixed style issues * Other linter fixes * Linter fix attempt 3 * Updated index.json with new whl * Fixing linter problems that didn't show up before * Fixed one more error in the help file * Updating new whl's sha in index.json * Bumping version to 0.8.0 * Update extension to new franework; add Oracle to PostgreSQL scenario. * Fixed styling issues * Added copyright info
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions: