Skip to content

[Containerapp] az containerapp create/update: Fix --bind/--unbind when cloud is not AzureCloud#8405

Merged
yanzhudd merged 1 commit intoAzure:mainfrom
Greedygre:xinyu/20250108_fix_mooncake
Jan 8, 2025
Merged

[Containerapp] az containerapp create/update: Fix --bind/--unbind when cloud is not AzureCloud#8405
yanzhudd merged 1 commit intoAzure:mainfrom
Greedygre:xinyu/20250108_fix_mooncake

Conversation

@Greedygre
Copy link
Copy Markdown
Contributor

@Greedygre Greedygre commented Jan 8, 2025 •
edited
Loading

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az containerapp create/updtae: Fix --bind/--unbind for java component when cloud is not AzureCloud
Currently when customer is using AzureChinaCloud, the command throw error due to it always list service connector, but service connector is not supported on AzureChinaCloud.

cli.azure.cli.core.azclierror: (pii). Status: Response_Status.Status_IncorrectConfiguration, Error code: 3399614475, Tag: 508634112

image

Tested by change the location to chinaeast3:
image

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link
Copy Markdown

azure-client-tools-bot-prd bot commented Jan 8, 2025 •
edited
Loading

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd
Copy link
Copy Markdown

azure-client-tools-bot-prd bot commented Jan 8, 2025

Hi @Greedygre,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@azure-client-tools-bot-prd
Copy link
Copy Markdown

azure-client-tools-bot-prd bot commented Jan 8, 2025

Hi @Greedygre,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Jan 8, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Auto-Assign Auto assign by bot label Jan 8, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 8, 2025

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 8, 2025

Hi @Greedygre

Release Suggestions

Module: containerapp

  • Update VERSION to 1.1.0b2 in src/containerapp/setup.py

Notes

@yanzhudd
Copy link
Copy Markdown
Contributor

yanzhudd commented Jan 8, 2025

please add some tests for the fix to verify if it could meet your expectations.

@Greedygre
Copy link
Copy Markdown
Contributor Author

Greedygre commented Jan 8, 2025 •
edited
Loading

please add some tests for the fix to verify if it could meet your expectations.

Hi @yonzhan
The test test_containerapp_java_component has cover my case, change the config location to chinaeast3 then run the test can pass.
image

@yanzhudd yanzhudd merged commit 1488170 into Azure:main Jan 8, 2025
ksayid pushed a commit to SethHollandsworth/azure-cli-extensions that referenced this pull request Jan 8, 2025
@Greedygre @ksayid
[Containerapp] az containerapp create/update: Fix --bind/--unbind w…
8de67e2 
…hen cloud is not AzureCloud (Azure#8405)
Jenniferyingni pushed a commit to Jenniferyingni/azure-cli-extensions that referenced this pull request Feb 9, 2025
@Greedygre
[Containerapp] az containerapp create/update: Fix --bind/--unbind w…
1c396e1 
…hen cloud is not AzureCloud (Azure#8405)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yanzhudd yanzhudd yanzhudd approved these changes

@howang-ms howang-ms Awaiting requested review from howang-ms howang-ms is a code owner

@Juliehzl Juliehzl Awaiting requested review from Juliehzl Juliehzl is a code owner

@yonzhan yonzhan Awaiting requested review from yonzhan

@wangzelin007 wangzelin007 Awaiting requested review from wangzelin007

@zhoxing-ms zhoxing-ms Awaiting requested review from zhoxing-ms

@jsntcy jsntcy Awaiting requested review from jsntcy

@ruslany ruslany Awaiting requested review from ruslany

@sanchitmehta sanchitmehta Awaiting requested review from sanchitmehta

@ebencarek ebencarek Awaiting requested review from ebencarek

@JennyLawrance JennyLawrance Awaiting requested review from JennyLawrance

@vinisoto vinisoto Awaiting requested review from vinisoto

@chinadragon0515 chinadragon0515 Awaiting requested review from chinadragon0515

@vturecek vturecek Awaiting requested review from vturecek

@torosent torosent Awaiting requested review from torosent

@pagariyaalok pagariyaalok Awaiting requested review from pagariyaalok

@jijohn14 jijohn14 Awaiting requested review from jijohn14

@kairu-ms kairu-ms Awaiting requested review from kairu-ms

+2 more reviewers

@ShichaoQiu ShichaoQiu ShichaoQiu approved these changes

@Caoxuyang Caoxuyang Caoxuyang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@zhoxing-ms zhoxing-ms

@kairu-ms kairu-ms

Labels

Auto-Assign Auto assign by bot ContainerApp

Projects

None yet

Milestone

February 2025 (2025-02-11)

Development

Successfully merging this pull request may close these issues.

8 participants

@Greedygre @yonzhan @yanzhudd @ShichaoQiu @Caoxuyang @zhoxing-ms @kairu-ms @xinyululala