Updating api version and changing namespace commands to scheduler by RyanLettieri · Pull Request #8362 · Azure/azure-cli-extensions

RyanLettieri · 2024-12-09T22:32:36Z

Associated AAZ PR: Azure/aaz#668

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
My extension version conforms to the Extension version schema

For new extensions:

My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

azure-client-tools-bot-prd · 2024-12-09T22:32:39Z

Hi @RyanLettieri,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

azure-client-tools-bot-prd · 2024-12-09T22:32:42Z

❌Azure CLI Extensions Breaking Change Test

❌durabletask

rule cmd_name rule_message suggest_message

❌ 1012 - SubgroupRemove durabletask namespace sub group durabletask namespace removed please confirm sub group durabletask namespace removed

❌ 1006 - ParaAdd durabletask taskhub create cmd durabletask taskhub create added parameter scheduler_name please remove parameter scheduler_name for cmd durabletask taskhub create

❌ 1007 - ParaRemove durabletask taskhub create cmd durabletask taskhub create removed parameter namespace_name please add back parameter namespace_name for cmd durabletask taskhub create

❌ 1007 - ParaRemove durabletask taskhub create cmd durabletask taskhub create removed parameter tags please add back parameter tags for cmd durabletask taskhub create

❌ 1006 - ParaAdd durabletask taskhub delete cmd durabletask taskhub delete added parameter scheduler_name please remove parameter scheduler_name for cmd durabletask taskhub delete

❌ 1007 - ParaRemove durabletask taskhub delete cmd durabletask taskhub delete removed parameter namespace_name please add back parameter namespace_name for cmd durabletask taskhub delete

❌ 1006 - ParaAdd durabletask taskhub list cmd durabletask taskhub list added parameter scheduler_name please remove parameter scheduler_name for cmd durabletask taskhub list

❌ 1007 - ParaRemove durabletask taskhub list cmd durabletask taskhub list removed parameter namespace_name please add back parameter namespace_name for cmd durabletask taskhub list

❌ 1006 - ParaAdd durabletask taskhub show cmd durabletask taskhub show added parameter scheduler_name please remove parameter scheduler_name for cmd durabletask taskhub show

❌ 1007 - ParaRemove durabletask taskhub show cmd durabletask taskhub show removed parameter namespace_name please add back parameter namespace_name for cmd durabletask taskhub show

❌ 1006 - ParaAdd durabletask taskhub update cmd durabletask taskhub update added parameter scheduler_name please remove parameter scheduler_name for cmd durabletask taskhub update

❌ 1007 - ParaRemove durabletask taskhub update cmd durabletask taskhub update removed parameter namespace_name please add back parameter namespace_name for cmd durabletask taskhub update

❌ 1007 - ParaRemove durabletask taskhub update cmd durabletask taskhub update removed parameter tags please add back parameter tags for cmd durabletask taskhub update

⚠️ 1011 - SubgroupAdd durabletask scheduler sub group durabletask scheduler added

⚠️ 1006 - ParaAdd durabletask taskhub create cmd durabletask taskhub create added parameter no_wait

⚠️ 1006 - ParaAdd durabletask taskhub delete cmd durabletask taskhub delete added parameter no_wait

⚠️ 1006 - ParaAdd durabletask taskhub update cmd durabletask taskhub update added parameter no_wait

⚠️ 1001 - CmdAdd durabletask taskhub wait cmd durabletask taskhub wait added

yonzhan · 2024-12-09T22:32:50Z

Thank you for your contribution! We will review the pull request and get back to you soon.

github-actions · 2024-12-09T22:32:52Z

🚫All pull requests will be blocked to merge until Jan 6, 2025 due to CCOA

github-actions · 2024-12-09T22:33:35Z

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

github-actions · 2024-12-09T22:36:36Z

For more info about extension versioning, please refer to Extension version schema

torosent · 2024-12-10T00:10:06Z

@yonzhan , @kairu-ms Can we file an exception for CCOA?

kairu-ms · 2024-12-10T05:33:16Z

/azp run

azure-pipelines · 2024-12-10T05:33:28Z

Azure Pipelines successfully started running 2 pipeline(s).

src/durabletask/azext_durabletask/aaz/latest/durabletask/scheduler/_create.py

kairu-ms · 2024-12-31T01:44:29Z

/azp run

azure-pipelines · 2024-12-31T01:44:40Z

Azure Pipelines successfully started running 2 pipeline(s).

kairu-ms · 2024-12-31T01:45:59Z

Please make sure the following breaking changes are expected

❌Azure CLI Extensions Breaking Change Test

❌durabletask

rule
cmd_name
rule_message
suggest_message

❌ 1012 - SubgroupRemove
durabletask namespace
sub group durabletask namespace removed
please confirm sub group durabletask namespace removed

❌ 1006 - ParaAdd
durabletask taskhub create
cmd durabletask taskhub create added parameter scheduler_name
please remove parameter scheduler_name for cmd durabletask taskhub create

❌ 1007 - ParaRemove
durabletask taskhub create
cmd durabletask taskhub create removed parameter namespace_name
please add back parameter namespace_name for cmd durabletask taskhub create

❌ 1007 - ParaRemove
durabletask taskhub create
cmd durabletask taskhub create removed parameter tags
please add back parameter tags for cmd durabletask taskhub create

❌ 1006 - ParaAdd
durabletask taskhub delete
cmd durabletask taskhub delete added parameter scheduler_name
please remove parameter scheduler_name for cmd durabletask taskhub delete

❌ 1007 - ParaRemove
durabletask taskhub delete
cmd durabletask taskhub delete removed parameter namespace_name
please add back parameter namespace_name for cmd durabletask taskhub delete

❌ 1006 - ParaAdd
durabletask taskhub list
cmd durabletask taskhub list added parameter scheduler_name
please remove parameter scheduler_name for cmd durabletask taskhub list

❌ 1007 - ParaRemove
durabletask taskhub list
cmd durabletask taskhub list removed parameter namespace_name
please add back parameter namespace_name for cmd durabletask taskhub list

❌ 1006 - ParaAdd
durabletask taskhub show
cmd durabletask taskhub show added parameter scheduler_name
please remove parameter scheduler_name for cmd durabletask taskhub show

❌ 1007 - ParaRemove
durabletask taskhub show
cmd durabletask taskhub show removed parameter namespace_name
please add back parameter namespace_name for cmd durabletask taskhub show

❌ 1006 - ParaAdd
durabletask taskhub update
cmd durabletask taskhub update added parameter scheduler_name
please remove parameter scheduler_name for cmd durabletask taskhub update

❌ 1007 - ParaRemove
durabletask taskhub update
cmd durabletask taskhub update removed parameter namespace_name
please add back parameter namespace_name for cmd durabletask taskhub update

❌ 1007 - ParaRemove
durabletask taskhub update
cmd durabletask taskhub update removed parameter tags
please add back parameter tags for cmd durabletask taskhub update

Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com>

kairu-ms · 2025-01-08T05:53:09Z

/azp run

azure-pipelines · 2025-01-08T05:53:21Z

Azure Pipelines successfully started running 2 pipeline(s).

azclibot · 2025-01-08T06:47:45Z

[Release] Update index.json for extension [ durabletask ] : https://dev.azure.com/msazure/One/_build/results?buildId=111969271&view=results

…ure#8362) * Updating api version and changing namespace commands to scheduler Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> * Updating some docs and upgrading version Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> * Expanding sku into 2 separate arguments Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> --------- Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com>

azure-client-tools-bot-prd bot added this to the January 2025 (2025-01-14) milestone Dec 9, 2024

github-actions bot added the do-not-merge label Dec 9, 2024

RyanLettieri mentioned this pull request Dec 9, 2024

Updating api version and changing namespace commands to scheduler Azure/aaz#643

Closed

yonzhan requested review from jsntcy and kairu-ms December 9, 2024 23:56

yonzhan assigned kairu-ms Dec 9, 2024

RyanLettieri force-pushed the main branch from e02fc6f to a671cf6 Compare December 10, 2024 17:24

berndverst reviewed Dec 18, 2024

View reviewed changes

src/durabletask/azext_durabletask/aaz/latest/durabletask/scheduler/_create.py Outdated Show resolved Hide resolved

RyanLettieri force-pushed the main branch from a4b8e0c to bd5f63e Compare January 7, 2025 16:09

RyanLettieri added 3 commits January 7, 2025 09:39

Updating api version and changing namespace commands to scheduler

979ba2c

Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com>

Updating some docs and upgrading version

c29d4a8

Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com>

Expanding sku into 2 separate arguments

35a7bcd

Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com>

RyanLettieri force-pushed the main branch from bd5f63e to 35a7bcd Compare January 7, 2025 16:41

RyanLettieri mentioned this pull request Jan 8, 2025

Regenerating scheduler commands Azure/aaz#668

Merged

kairu-ms removed the do-not-merge label Jan 8, 2025

kairu-ms approved these changes Jan 8, 2025

View reviewed changes

kairu-ms merged commit a4d59c7 into Azure:main Jan 8, 2025

Conversation

RyanLettieri commented Dec 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Related command

General Guidelines

About Extension Publish

Uh oh!

azure-client-tools-bot-prd bot commented Dec 9, 2024

Uh oh!

azure-client-tools-bot-prd bot commented Dec 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yonzhan commented Dec 9, 2024

Uh oh!

github-actions bot commented Dec 9, 2024

Uh oh!

github-actions bot commented Dec 9, 2024

CodeGen Tools Feedback Collection

Uh oh!

github-actions bot commented Dec 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

torosent commented Dec 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kairu-ms commented Dec 10, 2024

Uh oh!

azure-pipelines bot commented Dec 10, 2024

Uh oh!

Uh oh!

kairu-ms commented Dec 31, 2024

Uh oh!

azure-pipelines bot commented Dec 31, 2024

Uh oh!

kairu-ms commented Dec 31, 2024

Uh oh!

kairu-ms commented Jan 8, 2025

Uh oh!

azure-pipelines bot commented Jan 8, 2025

Uh oh!

azclibot commented Jan 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

RyanLettieri commented Dec 9, 2024 •

edited

Loading

azure-client-tools-bot-prd bot commented Dec 9, 2024 •

edited

Loading

github-actions bot commented Dec 9, 2024 •

edited

Loading

torosent commented Dec 10, 2024 •

edited

Loading