Skip to content

[Spring] Detect failed Update App operation during polling#8349

Merged
zhoxing-ms merged 3 commits intoAzure:mainfrom
domainname:jeffhuang/fix-failed
Jan 8, 2025
Merged

[Spring] Detect failed Update App operation during polling#8349
zhoxing-ms merged 3 commits intoAzure:mainfrom
domainname:jeffhuang/fix-failed

Conversation

@domainname
Copy link
Copy Markdown
Contributor

@domainname domainname commented Nov 28, 2024

Update App operation may fail due to quota usage. So I'm adding a few lines to detect such a failure during polling.

@azure-client-tools-bot-prd
Copy link
Copy Markdown

azure-client-tools-bot-prd bot commented Nov 28, 2024 •
edited
Loading

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd
Copy link
Copy Markdown

azure-client-tools-bot-prd bot commented Nov 28, 2024

Hi @domainname,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Nov 28, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Auto-Assign Auto assign by bot label Nov 28, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 28, 2024

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 28, 2024 •
edited
Loading

yuwzho
yuwzho reviewed Nov 28, 2024
View reviewed changes
@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Dec 16, 2024

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Dec 16, 2024

Azure Pipelines successfully started running 2 pipeline(s).

zhoxing-ms
zhoxing-ms reviewed Dec 16, 2024
View reviewed changes
src/spring/setup.py
# TODO: Confirm this is the right version number you want and it matches your
# HISTORY.rst entry.
VERSION = '1.26.0'
VERSION = '1.26.1'
Copy link
Copy Markdown
Contributor

@zhoxing-ms zhoxing-ms Dec 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to the impact of CCOA, if you want to merge this PR in advance, please do not upgrade the extension version for now

@yanzhudd yanzhudd closed this Dec 16, 2024
@yanzhudd yanzhudd reopened this Dec 16, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 16, 2024

🚫All pull requests will be blocked to merge until Jan 6, 2025 due to CCOA

@zhoxing-ms zhoxing-ms merged commit 744f874 into Azure:main Jan 8, 2025
@domainname domainname deleted the jeffhuang/fix-failed branch January 8, 2025 08:29
@azclibot
Copy link
Copy Markdown
Collaborator

azclibot commented Jan 8, 2025

[Release] Update index.json for extension [ spring ] : https://dev.azure.com/msazure/One/_build/results?buildId=111975412&view=results

ksayid pushed a commit to SethHollandsworth/azure-cli-extensions that referenced this pull request Jan 8, 2025
@domainname @ksayid
[Spring] Detect failed Update App operation during polling (Azure#8349)
b75d70f
Jenniferyingni pushed a commit to Jenniferyingni/azure-cli-extensions that referenced this pull request Feb 9, 2025
@domainname
[Spring] Detect failed Update App operation during polling (Azure#8349)
7afce9e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhoxing-ms zhoxing-ms zhoxing-ms approved these changes

@kairu-ms kairu-ms Awaiting requested review from kairu-ms

@necusjz necusjz Awaiting requested review from necusjz

@yonzhan yonzhan Awaiting requested review from yonzhan

@yanzhudd yanzhudd Awaiting requested review from yanzhudd

+1 more reviewer

@yuwzho yuwzho yuwzho left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@zhoxing-ms zhoxing-ms

@kairu-ms kairu-ms

Labels

Auto-Assign Auto assign by bot do-not-merge

Projects

None yet

Milestone

January 2025 (2025-01-14)

Development

Successfully merging this pull request may close these issues.

7 participants

@domainname @yonzhan @azclibot @yuwzho @zhoxing-ms @kairu-ms @yanzhudd