[containerapp] Add new options for labels mode#8324
Conversation
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| containerapp create | cmd containerapp create added parameter target_label |
||
| containerapp create | cmd containerapp create update parameter revisions_mode: updated property choices from ['multiple', 'single'] to ['labels', 'multiple', 'single'] |
||
| containerapp label-history | sub group containerapp label-history added |
||
| containerapp revision set-mode | cmd containerapp revision set-mode added parameter target_label |
||
| containerapp revision set-mode | cmd containerapp revision set-mode update parameter mode: updated property choices from ['multiple', 'single'] to ['labels', 'multiple', 'single'] |
||
| containerapp up | cmd containerapp up added parameter revisions_mode |
||
| containerapp up | cmd containerapp up added parameter target_label |
||
| containerapp update | cmd containerapp update added parameter revisions_mode |
||
| containerapp update | cmd containerapp update added parameter target_label |
|
Hi @Tratcher, |
|
Hi @Tratcher, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
Hi @Tratcher Release SuggestionsModule: containerapp
Notes
|
|
/azp run |
|
Commenter does not have sufficient privileges for PR 8324 in repo Azure/azure-cli-extensions |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
Hi @Tratcher |
| if ingress and not target_port: | ||
| target_port = 80 | ||
| logger.warning("No ingress provided, defaulting to port 80. Try `az containerapp up --ingress %s --target-port <port>` to set a custom port.", ingress) | ||
| if ingress and not target_port and target_port != 0: | ||
| target_port = 0 | ||
| logger.warning("No target-port provided, defaulting to auto-detect. Try `az containerapp up --ingress %s --target-port <port>` to set a custom port.", ingress) |
There was a problem hiding this comment.
Will this change lead to a breaking change?
There was a problem hiding this comment.
No, the auto-detection will still cover the old scenario where the app was listening on port 80.
| containerapp label-history show: | ||
| rule_exclusions: | ||
| - missing_command_test_coverage | ||
| containerapp label-history list: | ||
| rule_exclusions: | ||
| - missing_command_test_coverage |
There was a problem hiding this comment.
Why not add some tests for these commands?
There was a problem hiding this comment.
The commands won't work properly until our next control plane deployment goes out, there was a change in the object structure. I can add tests after that.
This adds support for the new containerapp activeRevisionMode 'labels' mode and the associated target-label option. These are used when creating or updating applications. There are also new commands to show the history of label revision assignments.
All commands except label-history already exist and need to be overridden by the extension to support these new features.
Needs tests.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)