NFSAAS-2316 Update to R4 RP standard (#49)#800
Merged
tjprescott merged 2 commits intoAzure:masterfrom Jun 20, 2019
Merged
Conversation
And fix merge issues from previous PR
|
If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR: |
* NFSAAS-2316 udpate to R4 RP standard And fix merge issues from previous PR * NFSAAS-2316 Update to R4 RP standard
tjprescott
approved these changes
Jun 20, 2019
Member
tjprescott
left a comment
There was a problem hiding this comment.
Approving, but do you plan to publish a version of the extension that is compatible with 2.0.67+?
Contributor
Author
|
@tjprescott yes, I will create a new PR for that shortly. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And fix merge issues from previous (closed) PR
#742
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions: