Skip to content

Update max cli core version#742

Closed
leonardbf wants to merge 0 commit intoAzure:masterfrom
leonardbf:master
Closed

Update max cli core version#742
leonardbf wants to merge 0 commit intoAzure:masterfrom
leonardbf:master

Conversation

@leonardbf
Copy link
Copy Markdown
Contributor

@leonardbf leonardbf commented Jun 4, 2019

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

@leonardbf leonardbf requested a review from tjprescott as a code owner June 4, 2019 20:33
@azuresdkci
Copy link
Copy Markdown

azuresdkci commented Jun 4, 2019

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:

docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/leonardbf/azure-cli-extensions.git@master#subdirectory=src/$EXT&egg=$EXT"

@leonardbf leonardbf closed this Jun 20, 2019
This was referenced Jun 20, 2019
Merged
Merged
Merged
@leonardbf
Copy link
Copy Markdown
Contributor Author

leonardbf commented Jun 20, 2019

This PR was closed when I pushed latest azure master to my fork. I've reapplied the changes here #800

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@tjprescott tjprescott tjprescott approved these changes

@limingu limingu limingu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@leonardbf @azuresdkci @tjprescott @limingu