Skip to content

[Spring] Fix stylecheck#7116

Merged
zhoxing-ms merged 2 commits intoAzure:mainfrom
jiec-msft:mason/fix-style-check-error
Dec 28, 2023
Merged

[Spring] Fix stylecheck#7116
zhoxing-ms merged 2 commits intoAzure:mainfrom
jiec-msft:mason/fix-style-check-error

Conversation

@jiec-msft
Copy link
Copy Markdown
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link
Copy Markdown

azure-client-tools-bot-prd bot commented Dec 26, 2023

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd
Copy link
Copy Markdown

Hi @jiec-msft,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Dec 26, 2023

Thank you for your contribution! We will review the pull request and get back to you soon.

@jiec-msft jiec-msft changed the title Tmp commit [Spring] Fix stylecheck Dec 26, 2023
@jiec-msft jiec-msft force-pushed the mason/fix-style-check-error branch 2 times, most recently from c6a953a to 06a9146 Compare December 27, 2023 11:29
@jiec-msft jiec-msft force-pushed the mason/fix-style-check-error branch from fd65c2c to b1bf789 Compare December 27, 2023 14:22
@jiec-msft jiec-msft marked this pull request as ready for review December 28, 2023 06:28
Copy link
Copy Markdown
Contributor

@zhoxing-ms zhoxing-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhoxing-ms zhoxing-ms merged commit 8f52938 into Azure:main Dec 28, 2023
ddouglas-msft pushed a commit to ddouglas-msft/azure-cli-extensions that referenced this pull request Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants