Skip to content

[Stack-hci] az stack-hci extension create: Change --settings/--protected-settings as custom properties#6694

Merged
kairu-ms merged 2 commits intoAzure:mainfrom
Jing-song:jins-stackhci-setting
Aug 29, 2023
Merged

[Stack-hci] az stack-hci extension create: Change --settings/--protected-settings as custom properties#6694
kairu-ms merged 2 commits intoAzure:mainfrom
Jing-song:jins-stackhci-setting

Conversation

@Jing-song
Copy link
Copy Markdown
Contributor

@Jing-song Jing-song commented Aug 28, 2023

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az stack-hci extension create
AAZ model: Azure/aaz#296

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@Jing-song Jing-song requested a review from zhoxing-ms as a code owner August 28, 2023 07:27
@azure-client-tools-bot-prd
Copy link
Copy Markdown

azure-client-tools-bot-prd bot commented Aug 28, 2023 •
edited
Loading

❌Azure CLI Extensions Breaking Change Test
❌stack-hci
rule cmd_name rule_message suggest_message
❌ 1009 - ParaPropRemove stack-hci extension create cmd stack-hci extension create update parameter protected_settings: removed property nargs=+ please add back property nargs=+ for parameter protected_settings of cmd stack-hci extension create
❌ 1010 - ParaPropUpdate stack-hci extension create cmd stack-hci extension create update parameter protected_settings: updated property aaz_type from AAZObjectArg to AAZFreeFormDictArg please change property aaz_type from AAZFreeFormDictArg to AAZObjectArg for parameter protected_settings of cmd stack-hci extension create
❌ 1010 - ParaPropUpdate stack-hci extension create cmd stack-hci extension create update parameter protected_settings: updated property type from Object to Dict<String, Any> please change property type from Dict<String, Any> to Object for parameter protected_settings of cmd stack-hci extension create
❌ 1009 - ParaPropRemove stack-hci extension create cmd stack-hci extension create update parameter settings: removed property nargs=+ please add back property nargs=+ for parameter settings of cmd stack-hci extension create
❌ 1010 - ParaPropUpdate stack-hci extension create cmd stack-hci extension create update parameter settings: updated property aaz_type from AAZObjectArg to AAZFreeFormDictArg please change property aaz_type from AAZFreeFormDictArg to AAZObjectArg for parameter settings of cmd stack-hci extension create
❌ 1010 - ParaPropUpdate stack-hci extension create cmd stack-hci extension create update parameter settings: updated property type from Object to Dict<String, Any> please change property type from Dict<String, Any> to Object for parameter settings of cmd stack-hci extension create
⚠️ 1006 - ParaAdd stack-hci extension list cmd stack-hci extension list added parameter pagination_limit
⚠️ 1006 - ParaAdd stack-hci extension list cmd stack-hci extension list added parameter pagination_token

@azure-client-tools-bot-prd
Copy link
Copy Markdown

azure-client-tools-bot-prd bot commented Aug 28, 2023

Hi @Jing-song,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Aug 28, 2023

Stack-hci

@yonzhan yonzhan requested review from jsntcy and kairu-ms August 28, 2023 08:29
@yonzhan yonzhan assigned kairu-ms and zhoxing-ms and unassigned kairu-ms Aug 28, 2023
@kairu-ms kairu-ms merged commit ec3f407 into Azure:main Aug 29, 2023
@azclibot
Copy link
Copy Markdown
Collaborator

azclibot commented Aug 29, 2023

[Release] Update index.json for extension [ stack-hci ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=86662&view=results

scrappywyrm pushed a commit to scrappywyrm/azure-cli-extensions that referenced this pull request Aug 30, 2023
@Jing-song @scrappywyrm
[Stack-hci] az stack-hci extension create: Change `--settings/--pro…
b0a09a0 
…tected-settings` as custom properties (Azure#6694)

* settings/protected-settings

* Update _create.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kairu-ms kairu-ms kairu-ms approved these changes

@zhoxing-ms zhoxing-ms Awaiting requested review from zhoxing-ms

@jsntcy jsntcy Awaiting requested review from jsntcy

Assignees

@zhoxing-ms zhoxing-ms

@kairu-ms kairu-ms

Labels

None yet

Projects

None yet

Milestone

September 2023 (2023-09-26)

Development

Successfully merging this pull request may close these issues.

5 participants

@Jing-song @yonzhan @azclibot @kairu-ms @zhoxing-ms