Add support for managed MySQL Flexible server by yash-nisar · Pull Request #6411 · Azure/azure-cli-extensions

yash-nisar · 2023-06-15T19:06:14Z

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

azure-client-tools-bot-prd · 2023-06-15T19:06:17Z

Hi @yash-nisar,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

yonzhan · 2023-06-15T19:06:26Z

Thank you for your contribution! We will review the pull request and get back to you soon.

yash-nisar · 2023-06-15T19:49:49Z

It takes ~6mins to provision a flexible mysql server from the command line so I don't think it's feasible to add ITs:

yash-nisar · 2023-06-15T20:04:49Z

Verified the binding works:

yash-nisar · 2023-06-15T20:07:07Z

Also could see env vars on curling the app:

AZURE_MYSQL_DATABASE=XX
AZURE_MYSQL_HOST=XX
AZURE_MYSQL_PASSWORD=XX
AZURE_MYSQL_PORT=XX
AZURE_MYSQL_SSL=XX
AZURE_MYSQL_USERNAME=XX

Command to bind:

az containerapp update -n appName -g rgName --bind mysqlName:mysqlconnName,username=XX,password=XX,database=XX

Greedygre · 2023-06-16T02:00:39Z

src/containerapp/azext_containerapp/_managed_service_utils.py

+        return {"linker_name": binding_name, "parameters": parameters, "resource_id": resource_id}
+
+
+class ManagedMySQLFlexibleUtils:


Please add tests for command
az containerapp create/update --bind to test the MySQL service binding.
Otherwise LGTM.

test function added, thank you.

zhoxing-ms · 2023-06-16T02:17:01Z

Could you please add some test case for this PR change?

yash-nisar · 2023-08-21T15:57:19Z

@bgashirabake is working on the tests and will continue this PR.

Note: Since it takes ~6 mins to provision a flexible mysql server, the runtime of the test is expected to increase.

azure-client-tools-bot-prd · 2023-08-22T05:17:09Z

️✔️Azure CLI Extensions Breaking Change Test

️✔️Non Breaking Changes

scrappywyrm · 2023-08-24T11:13:32Z

Could you please add some test case for this PR change?

done. could you please take a look when you get the chance. thank you!!

src/containerapp/azext_containerapp/tests/latest/test_containerapp_commands.py

…rapp_commands.py Co-authored-by: Xing Zhou <Zhou.Xing@microsoft.com>

Greedygre · 2023-08-28T10:38:37Z

Hi @zhoxing-ms @yanzhudd
Could you help to review and merge this PR? Thanks.

* Add support for managed MySQL Flexible server * fix * add change to history.rst * test add * fix duplicate env create cmd * test rerun * test update * Update src/containerapp/azext_containerapp/tests/latest/test_containerapp_commands.py Co-authored-by: Xing Zhou <Zhou.Xing@microsoft.com> --------- Co-authored-by: bgashirabake@gmail.com <bgashirabake@gmail.com> Co-authored-by: bgashirabake <85650284+bgashirabake@users.noreply.github.com> Co-authored-by: Xing Zhou <Zhou.Xing@microsoft.com>

azure-client-tools-bot-prd bot added this to the June 2023 (2023-07-04) milestone Jun 15, 2023

Add support for managed MySQL Flexible server

a8804b1

yash-nisar force-pushed the mysql-flexible branch from 0baab94 to a8804b1 Compare June 15, 2023 19:33

yonzhan requested review from yanzhudd and zhoxing-ms June 15, 2023 22:34

yonzhan assigned zhoxing-ms Jun 15, 2023

Greedygre reviewed Jun 16, 2023

View reviewed changes

scrappywyrm and others added 2 commits August 21, 2023 21:55

fix

4c39527

Merge branch 'main' into mysql-flexible

5f339a7

scrappywyrm added 3 commits August 21, 2023 22:18

add change to history.rst

119e208

test add

1fe2cf9

fix duplicate env create cmd

952277c

yonzhan modified the milestones: June 2023 (2023-07-04), Aug 2022 (2022-09-06), August 2023 (2023-09-05) Aug 24, 2023

scrappywyrm added 2 commits August 23, 2023 23:02

test rerun

e80b5d6

test update

199b9e7

Greedygre approved these changes Aug 24, 2023

View reviewed changes

zhoxing-ms reviewed Aug 25, 2023

View reviewed changes

src/containerapp/azext_containerapp/tests/latest/test_containerapp_commands.py Show resolved Hide resolved

Update src/containerapp/azext_containerapp/tests/latest/test_containe…

2ee138b

…rapp_commands.py Co-authored-by: Xing Zhou <Zhou.Xing@microsoft.com>

Greedygre approved these changes Aug 28, 2023

View reviewed changes

zhoxing-ms approved these changes Aug 28, 2023

View reviewed changes

zhoxing-ms merged commit 94b2e14 into Azure:main Aug 28, 2023

yash-nisar deleted the mysql-flexible branch September 6, 2023 20:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for managed MySQL Flexible server#6411

Add support for managed MySQL Flexible server#6411
zhoxing-ms merged 9 commits intoAzure:mainfrom
yash-nisar:mysql-flexible

yash-nisar commented Jun 15, 2023

Uh oh!

azure-client-tools-bot-prd bot commented Jun 15, 2023

Uh oh!

yonzhan commented Jun 15, 2023

Uh oh!

yash-nisar commented Jun 15, 2023

Uh oh!

yash-nisar commented Jun 15, 2023

Uh oh!

yash-nisar commented Jun 15, 2023

Uh oh!

Greedygre Jun 16, 2023 •

edited

Loading

Uh oh!

scrappywyrm Aug 24, 2023

Uh oh!

zhoxing-ms commented Jun 16, 2023

Uh oh!

yash-nisar commented Aug 21, 2023 •

edited

Loading

Uh oh!

azure-client-tools-bot-prd bot commented Aug 22, 2023 •

edited

Loading

Uh oh!

scrappywyrm commented Aug 24, 2023

Uh oh!

Uh oh!

Greedygre commented Aug 28, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

		return {"linker_name": binding_name, "parameters": parameters, "resource_id": resource_id}


		class ManagedMySQLFlexibleUtils:

Conversation

yash-nisar commented Jun 15, 2023

Related command

General Guidelines

About Extension Publish

Uh oh!

azure-client-tools-bot-prd bot commented Jun 15, 2023

Uh oh!

yonzhan commented Jun 15, 2023

Uh oh!

yash-nisar commented Jun 15, 2023

Uh oh!

yash-nisar commented Jun 15, 2023

Uh oh!

yash-nisar commented Jun 15, 2023

Uh oh!

Greedygre Jun 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

scrappywyrm Aug 24, 2023

Choose a reason for hiding this comment

Uh oh!

zhoxing-ms commented Jun 16, 2023

Uh oh!

yash-nisar commented Aug 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

azure-client-tools-bot-prd bot commented Aug 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

scrappywyrm commented Aug 24, 2023

Uh oh!

Uh oh!

Greedygre commented Aug 28, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Greedygre Jun 16, 2023 •

edited

Loading

yash-nisar commented Aug 21, 2023 •

edited

Loading

azure-client-tools-bot-prd bot commented Aug 22, 2023 •

edited

Loading