App Insights control plane by alexeldeib · Pull Request #600 · Azure/azure-cli-extensions

alexeldeib · 2019-03-26T17:28:32Z

Introduces commands for managing App Insights components and API keys belonging to those resources. See Azure/azure-cli#5543

TODO

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

Have you run ./scripts/ci/test_static.sh locally? (pip install pylint flake8 required)
Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

My extension description/summary conforms to the Extension Summary Guidelines.

azuresdkci · 2019-03-26T17:28:34Z

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:

docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/alexeldeib/azure-cli-extensions.git@aicontrolplane#subdirectory=src/$EXT&egg=$EXT"

alexeldeib · 2019-03-26T19:14:16Z

@williexu could you help me decode this CI error? is --kind not a valid flag?

-  FAIL: unrecognized_help_parameter_rule
    Help-Entry: `monitor app-insights component create` - The following parameter help names are invalid: --kind
    Help-Entry: `monitor app-insights component update` - The following parameter help names are invalid: --kind

The associated help text (also tried defining the --kind parameter explicitly here, but maybe I messed it up?):

helps['monitor app-insights component create'] = """
    type: command
    short-summary: Create a new Application Insights resource.
    parameters:
      - name: --application-type
        type: string
        short-summary: Type of application being monitored. Possible values include 'web', 'other'. Default value is'web' .
    examples:
      - name: Create a component with kind web and location.
        text: |
          az monitor app-insights component create --app demoApp --location westus2 --kind web -g demoRg --application-type web
"""

helps['monitor app-insights component update'] = """
    type: command
    short-summary: Update properties on an existing Application Insights resource. The primary value which can be updated is kind, which customizes the UI experience.
    examples:
      - name: Update a component with kind web.
        text: |
          az monitor app-insights component update --app demoApp --kind web -g demoRg
"""

tjprescott · 2019-03-27T19:33:36Z

@alexeldeib the problem is that you need to specify the long and short option:

- name: --kind -k

alexeldeib · 2019-04-08T05:14:45Z

@tjprescott could you review this? After those fixes + additions, this looks okay to me.

alexeldeib · 2019-04-11T19:40:11Z

Bump 😃 cc @williexu

yugangw-msft

A few comments. The rest LGTM

src/application-insights/azext_applicationinsights/custom.py

src/application-insights/azext_applicationinsights/_help.py

src/application-insights/azext_applicationinsights/_params.py

alexeldeib · 2019-04-12T22:59:11Z

@yugangw-msft fixed all comments. Two test errors look related to AKS. Additionally, now that I have az monitor api-key list, i'm getting an error from CI on no --ids with list commands (but api-keys are under components). Can I disable this error?

Otherwise, think this is okay again.

alexeldeib · 2019-04-15T20:17:38Z

@yugangw-msft bringing this back after the weekend, barring changes on the show with ids, I think this is good on my end.

yugangw-msft · 2019-04-16T00:18:23Z

@alexeldeib, you can disable the error. Can you please rebase to get CI green?

alexeldeib · 2019-04-16T00:23:25Z

Whoops, messed that up. One sec...

alexeldeib · 2019-04-16T00:24:44Z

@yugangw-msft ~~ok, now the rebase is fixed~~ Nope, still needs work... If you can let me know the tag to disable, I will add it. I'm checking other commands if they have something similar but haven't found it yet,

alexeldeib · 2019-04-16T01:37:14Z

Okay, actually fixed.

* Add new version of aks-preview in index.json (Azure#634) * Azure Event Grid 0.4.1 (Azure#633) * Azure Event Grid 0.4.1 * fix white space * fix style issues * style fixes * style comment spaces fixes * more style fixes * mossing hesder * Address CR comment * move json generated SDK files to vendored_sdks folder and update related imports * revert index changes until we publish final extension * Address CR comments by removing unnecessary parameters * Fix style * update index.json file * fix index.json after running azdev extension update-index * fix index.json after running azdev extension update-index * add missing __init__.py * fix init files * fix new line in init files * update location of vendored_sdks and update index.json * fix help errors and update index.json file accordingly * [aks-preview]: fix python3-only super() syntax (Azure#641) * [storage-preview] release azcopy 10.0.9 (Azure#639) * [storage-preview] release azcopy 10.0.9 * Fix indent * [storage-preview] pulish 0.2.4 (Azure#642) * App Insights control plane (Azure#600) * Remove 'preview' from Dev Spaces (Azure#638) * Update PULL_REQUEST_TEMPLATE.md (Azure#645) Refer to azdev. * setting default vm size for windows (Azure#637) * SQL: make "up" command work end to end (Azure#644) * Update requirements.txt Bump for Jinja security vulnerability

* NFSAAS-2102 update to R3.5 (#29) * Nfsaas 2102 update to r3 5 (#30) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * Nfsaas 2102 update to r3 5 (#31) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * Nfsaas 2102 update to r3 5 (#32) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * Nfsaas 2102 update to r3 5 (#33) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * Nfsaas 2102 update to r3 5 (#34) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * Nfsaas 2102 update to r3 5 (#35) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * Nfsaas 2102 update to r3 5 (#36) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * Nfsaas 2102 update to r3 5 (#37) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * Nfsaas 2102 update to r3 5 (#38) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * Nfsaas 2102 update to r3 5 (#39) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * Nfsaas 2102 update to r3 5 (#40) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * Merge azure master back to fork. (#41) * Add new version of aks-preview in index.json (#634) * Azure Event Grid 0.4.1 (#633) * Azure Event Grid 0.4.1 * fix white space * fix style issues * style fixes * style comment spaces fixes * more style fixes * mossing hesder * Address CR comment * move json generated SDK files to vendored_sdks folder and update related imports * revert index changes until we publish final extension * Address CR comments by removing unnecessary parameters * Fix style * update index.json file * fix index.json after running azdev extension update-index * fix index.json after running azdev extension update-index * add missing __init__.py * fix init files * fix new line in init files * update location of vendored_sdks and update index.json * fix help errors and update index.json file accordingly * [aks-preview]: fix python3-only super() syntax (#641) * [storage-preview] release azcopy 10.0.9 (#639) * [storage-preview] release azcopy 10.0.9 * Fix indent * [storage-preview] pulish 0.2.4 (#642) * App Insights control plane (#600) * Remove 'preview' from Dev Spaces (#638) * Update PULL_REQUEST_TEMPLATE.md (#645) Refer to azdev. * setting default vm size for windows (#637) * SQL: make "up" command work end to end (#644) * Update requirements.txt Bump for Jinja security vulnerability

* NFSAAS-2102 update to R3.5 (Azure#29) * Nfsaas 2102 update to r3 5 (Azure#30) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * Nfsaas 2102 update to r3 5 (Azure#31) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * Nfsaas 2102 update to r3 5 (Azure#32) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * Nfsaas 2102 update to r3 5 (Azure#33) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * Nfsaas 2102 update to r3 5 (Azure#34) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * Nfsaas 2102 update to r3 5 (Azure#35) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * Nfsaas 2102 update to r3 5 (Azure#36) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * Nfsaas 2102 update to r3 5 (Azure#37) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * Nfsaas 2102 update to r3 5 (Azure#38) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * Nfsaas 2102 update to r3 5 (Azure#39) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * Nfsaas 2102 update to r3 5 (Azure#40) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * Merge azure master back to fork. (Azure#41) * Add new version of aks-preview in index.json (Azure#634) * Azure Event Grid 0.4.1 (Azure#633) * Azure Event Grid 0.4.1 * fix white space * fix style issues * style fixes * style comment spaces fixes * more style fixes * mossing hesder * Address CR comment * move json generated SDK files to vendored_sdks folder and update related imports * revert index changes until we publish final extension * Address CR comments by removing unnecessary parameters * Fix style * update index.json file * fix index.json after running azdev extension update-index * fix index.json after running azdev extension update-index * add missing __init__.py * fix init files * fix new line in init files * update location of vendored_sdks and update index.json * fix help errors and update index.json file accordingly * [aks-preview]: fix python3-only super() syntax (Azure#641) * [storage-preview] release azcopy 10.0.9 (Azure#639) * [storage-preview] release azcopy 10.0.9 * Fix indent * [storage-preview] pulish 0.2.4 (Azure#642) * App Insights control plane (Azure#600) * Remove 'preview' from Dev Spaces (Azure#638) * Update PULL_REQUEST_TEMPLATE.md (Azure#645) Refer to azdev. * setting default vm size for windows (Azure#637) * SQL: make "up" command work end to end (Azure#644) * Update requirements.txt Bump for Jinja security vulnerability

* [image-copy] update to version 0.2.0 * [image-copy] update index for version 0.2.0 * switch to 2019-04-01 api version and enable windows agent pool (#612) * fixing az support for agent pools and mc * vendor in 2019-04-01 SDK * enableing windows profile * merge the latest official SDK * add secure prompt for windows admin password * fixing warnings * Policies should be global, remove location parameter and default it (#620) * bug fixes: missing service principal and network profile parameter validation (#626) * Pin max CLI version. (#630) * Update front door index to 0.1.5 (#632) * Fixes #629. (#631) * Update index.json. (#640) * Add new version of aks-preview in index.json (#634) * Azure Event Grid 0.4.1 (#633) * Azure Event Grid 0.4.1 * fix white space * fix style issues * style fixes * style comment spaces fixes * more style fixes * mossing hesder * Address CR comment * move json generated SDK files to vendored_sdks folder and update related imports * revert index changes until we publish final extension * Address CR comments by removing unnecessary parameters * Fix style * update index.json file * fix index.json after running azdev extension update-index * fix index.json after running azdev extension update-index * add missing __init__.py * fix init files * fix new line in init files * update location of vendored_sdks and update index.json * fix help errors and update index.json file accordingly * [aks-preview]: fix python3-only super() syntax (#641) * [storage-preview] release azcopy 10.0.9 (#639) * [storage-preview] release azcopy 10.0.9 * Fix indent * [storage-preview] pulish 0.2.4 (#642) * App Insights control plane (#600) * Remove 'preview' from Dev Spaces (#638) * Update PULL_REQUEST_TEMPLATE.md (#645) Refer to azdev. * setting default vm size for windows (#637) * SQL: make "up" command work end to end (#644) * Update requirements.txt Bump for Jinja security vulnerability * Update to RP standard release 3.5 (#29) (#627) * NFSAAS-2102 update to R3.5 (#29) * Nfsaas 2102 update to r3 5 (#30) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * Nfsaas 2102 update to r3 5 (#31) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * Nfsaas 2102 update to r3 5 (#32) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * Nfsaas 2102 update to r3 5 (#33) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * Nfsaas 2102 update to r3 5 (#34) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * Nfsaas 2102 update to r3 5 (#35) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * Nfsaas 2102 update to r3 5 (#36) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * Nfsaas 2102 update to r3 5 (#37) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * Nfsaas 2102 update to r3 5 (#38) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * Nfsaas 2102 update to r3 5 (#39) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * Nfsaas 2102 update to r3 5 (#40) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * Merge azure master back to fork. (#41) * Add new version of aks-preview in index.json (#634) * Azure Event Grid 0.4.1 (#633) * Azure Event Grid 0.4.1 * fix white space * fix style issues * style fixes * style comment spaces fixes * more style fixes * mossing hesder * Address CR comment * move json generated SDK files to vendored_sdks folder and update related imports * revert index changes until we publish final extension * Address CR comments by removing unnecessary parameters * Fix style * update index.json file * fix index.json after running azdev extension update-index * fix index.json after running azdev extension update-index * add missing __init__.py * fix init files * fix new line in init files * update location of vendored_sdks and update index.json * fix help errors and update index.json file accordingly * [aks-preview]: fix python3-only super() syntax (#641) * [storage-preview] release azcopy 10.0.9 (#639) * [storage-preview] release azcopy 10.0.9 * Fix indent * [storage-preview] pulish 0.2.4 (#642) * App Insights control plane (#600) * Remove 'preview' from Dev Spaces (#638) * Update PULL_REQUEST_TEMPLATE.md (#645) Refer to azdev. * setting default vm size for windows (#637) * SQL: make "up" command work end to end (#644) * Update requirements.txt Bump for Jinja security vulnerability * Update readme to reflect the latest SQL DB status * SQL up: update a typo * Update index.json for backwards compatability for Dev Spaces (#648) * update index.json for backwards compatability * fix maxCliVersion for dev-spaces-preview * revert dev-spaces minCliCoreVersion * update metadata for dev-spaces and dev-spaces-preview * update metadata for dev-spaces and dev-spaces-preview * sync workspaces * 0.5.0 release for Azure DevOps (#653) * [AKS]customizing node resource group (#636) * customizing node resource group * make 2.0 and 3.0 python work * add index * Onboard Azure Machine Learning Service CLI (#655) * [storage-preview] pulish 0.2.5 (#657) * [AKS] Add Azure policy addon (#651) * Add the Azure Policy Addon Support * Add azure-policy addon * Allow azure-policy addon in create * Update the index * Add the missing parameter description * 0.6.0 release for Azure DevOps (#660) * Upgrade AppConfig extension version from 0.4.0 to 0.5.0 (#661) * Upgrade AppConfig extension verstion from 0.4.0 to 0.5.0 * format downloadUrl * update wheel version to 0.30.0 * Update service principal secret for windows nodes (#662) * Release storage-preview 0.2.5 (#663) * Remove extra + (#664) * 0.7.0 release for Azure DevOps (#666) * 0.7.0 release for Azure DevOps * update sha * fix * remove botservice from index.json (#667) * [image-copy] fix temp_rg default valuet

Migrate `express-route-cross-connection` to AAZ

alexeldeib requested a review from tjprescott as a code owner March 26, 2019 17:28

alexeldeib force-pushed the aicontrolplane branch 2 times, most recently from df1514b to 9d656ce Compare April 6, 2019 02:27

yugangw-msft reviewed Apr 12, 2019

View reviewed changes

alexeldeib force-pushed the aicontrolplane branch from 41782eb to 0e3f20d Compare April 16, 2019 00:19

alexeldeib added 17 commits April 15, 2019 17:23

feat: add update command, new help info

34bfb19

fix: lint whitespace

0041ebd

fix: E302 new lines linting

83556f6

fix: summary and hash

974b3c5

fix: help and unused args

2a0c898

fix: update help for linting

26e63be

fix: sha

29a140a

fix: sha

3272003

fix: remove colon to make CI happy

06d44a7

fix: one more lint removal

8ddc243

fix: sha

67bf1cc

fix: extra param in help for apikey

2f1fc80

fix: api key create

db16e4c

fix: api_key_name -> api_key

3a621fb

fix: api_key_name -> api_key again

f95ab9d

fix: sha

77e6b77

fix: params

c261d1b

alexeldeib added 16 commits April 15, 2019 17:23

fix: undo help

e04f533

fix: short option on flag

4b0dc14

fix: hashs

a219a4f

fix: flag example?

4036358

fix: hash and flag

89cc49a

fix: minor features and tests

cc11393

fix: hash

194343f

fix: hash and spaces

8cc8da2

fix: ci errors

c757ce7

fix: missed on dangerous arg

0bad6b7

fix: help

b35934d

fix: flake8

a2172ab

fix: blank line

f4fc416

fix: sha?

49aed9e

fix: revert bad digests

13bea65

fix: not empty list doesn't work?

7ea3228

alexeldeib force-pushed the aicontrolplane branch from 0e3f20d to 7ea3228 Compare April 16, 2019 00:23

alexeldeib added 2 commits April 15, 2019 18:12

fix: sha after rebase

76f8dea

fix: wrong sha

90ba93b

yugangw-msft approved these changes Apr 16, 2019

View reviewed changes

yugangw-msft merged commit 1148304 into Azure:master Apr 16, 2019

tamirkamara pushed a commit to tamirkamara/azure-cli-extensions that referenced this pull request May 3, 2019

App Insights control plane (Azure#600)

202c6a9

ShreyaAnand pushed a commit to ShreyaAnand/azure-cli-extensions that referenced this pull request Dec 31, 2024

Merge pull request Azure#600 from Jing-song/jins-exp-cross

d7e719a

Migrate `express-route-cross-connection` to AAZ

Conversation

alexeldeib commented Mar 26, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

TODO

General Guidelines

Uh oh!

azuresdkci commented Mar 26, 2019

Uh oh!

alexeldeib commented Mar 26, 2019

Uh oh!

tjprescott commented Mar 27, 2019

Uh oh!

alexeldeib commented Apr 8, 2019

Uh oh!

alexeldeib commented Apr 11, 2019

Uh oh!

yugangw-msft left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alexeldeib commented Apr 12, 2019

Uh oh!

alexeldeib commented Apr 15, 2019

Uh oh!

yugangw-msft commented Apr 16, 2019

Uh oh!

alexeldeib commented Apr 16, 2019

Uh oh!

alexeldeib commented Apr 16, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alexeldeib commented Apr 16, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

alexeldeib commented Mar 26, 2019 •

edited

Loading

alexeldeib commented Apr 16, 2019 •

edited

Loading