Adding feature to export snapshots instead of images. #583
Merged
tjprescott merged 7 commits intoAzure:masterfrom Apr 2, 2019
bebattis:copy-snapshot-feature
Merged
Adding feature to export snapshots instead of images. #583tjprescott merged 7 commits intoAzure:masterfrom bebattis:copy-snapshot-feature
tjprescott merged 7 commits intoAzure:masterfrom
bebattis:copy-snapshot-feature
Conversation
… non-generalized osStates to be copied and deployed across regions.
|
If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR: |
Contributor
Author
|
EDIT: Needed to add this line to the create_target.py Not too sure on this error... should I un-comment "pylint: disable=too-many-statements" ? |
yugangw-msft
approved these changes
Mar 27, 2019
tamirkamara
approved these changes
Apr 1, 2019
3 tasks
ShreyaAnand
pushed a commit
to ShreyaAnand/azure-cli-extensions
that referenced
this pull request
Dec 31, 2024
[connectedmachine] release 2024-07-10 stable api
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows for non-generalized (or non-sysprepped) osStates to be copied and deployed across regions. Will work as approved work around for copying VMs across regions which need to maintain identical runtimes.
Spoke with @tamirkamara on this previously offline. I was able to get the extension configured locally with the Azdev tools and ran a quick test to replicate a single region. This was successful. As far as development best practices, there may be a better way to do this, but for now I've essentially added two if/else statements and the switch parameter
--export-as-snapshotwhich will 1) skip the image creation, and 2) place the temp snapshots into thetarget_resource_groupvs thetransient_resource-groupdepending on what the desired output is.LMK if there is anything else that needs testing or improvement. Feel free to reach out again directly.