Skip to content

[AKS] Polish scripts used in aks pr check-in test pipeline#3415

Merged
Juliehzl merged 2 commits intoAzure:masterfrom
FumingZhang:fuming/fix-pipeline-scripts
May 25, 2021
Merged

[AKS] Polish scripts used in aks pr check-in test pipeline#3415
Juliehzl merged 2 commits intoAzure:masterfrom
FumingZhang:fuming/fix-pipeline-scripts

Conversation

@FumingZhang
Copy link
Copy Markdown
Member

This PR aims to polish the shell scripts used in aks pr check-in pipeline. The main changes are as follows;

  • Update all shell scripts, add required variable checks, set bash options in a clearer way
  • Update the way to forcibly update the azure-cli command index to ensure that the aks-preview command has been loaded before performing tests
  • Define the trigger method in the pipeline yaml file
  • Modify the implementation of AKSCustomResourceGroupPreparer to inherit (same as azure-cli)

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@FumingZhang
Copy link
Copy Markdown
Member Author

PR#3389

@yonzhan yonzhan requested review from Juliehzl and zhoxing-ms May 21, 2021 16:37
@yonzhan yonzhan added this to the S188 milestone May 21, 2021
@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented May 21, 2021

AKS

@Juliehzl Juliehzl merged commit c872a38 into Azure:master May 25, 2021
@FumingZhang FumingZhang deleted the fuming/fix-pipeline-scripts branch June 10, 2021 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants