[AKS] fix aks pr check-in test pipeline#3389
Merged
Juliehzl merged 8 commits intoAzure:masterfrom May 26, 2021
Merged
Conversation
Collaborator
|
AKS |
ac93c44 to
64ccde2
Compare
andyliuliming
requested changes
May 20, 2021
src/aks-preview/az_aks_tool/main.py
Outdated
Member
There was a problem hiding this comment.
could you please help add comments to the real code changes?
a huge PR is a bit hard to do review.
Member
Author
There was a problem hiding this comment.
sure, working on that
Member
Author
There was a problem hiding this comment.
Update key changes in PR description section.
andyliuliming
requested changes
May 21, 2021
Member
andyliuliming
left a comment
There was a problem hiding this comment.
please separate the non-logicial change with the real code chagne.
3 tasks
39360ba to
2d72ca1
Compare
2d72ca1 to
1b09a31
Compare
andyliuliming
approved these changes
May 26, 2021
Juliehzl
approved these changes
May 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Base on PR#3415, this PR further fix some other known issues of the AKS PR check-in test pipeline. The main changes are as follows:
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json.