Skip to content

[Alertsmanagement] Add experimental tag#1492

Merged
qwordy merged 52 commits intoAzure:masterfrom
qwordy:alertsmanagement-phase1
Apr 7, 2020
Merged

[Alertsmanagement] Add experimental tag#1492
qwordy merged 52 commits intoAzure:masterfrom
qwordy:alertsmanagement-phase1

Conversation

@qwordy
Copy link
Copy Markdown
Member

@qwordy qwordy commented Apr 2, 2020


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@jiasli
Copy link
Copy Markdown
Member

jiasli commented Apr 3, 2020

Do you mind rebase the commit to make the history cleaner? You can

  1. Checkout qwordy:alertsmanagement-phase1 branch
  2. Soft reset local alertsmanagement-phase1 branch to master. This keeps all local files unchanged
  3. Commit
  4. Force push to qwordy:alertsmanagement-phase1

@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Apr 3, 2020

Alertsmanagement

@qwordy
Copy link
Copy Markdown
Member Author

qwordy commented Apr 3, 2020

Do you mind rebase the commit to make the history cleaner? You can

1. Checkout `qwordy:alertsmanagement-phase1` branch

2. **Soft reset** local `alertsmanagement-phase1` branch to `master`. This keeps all local files unchanged

3. Commit

4. Force push to `qwordy:alertsmanagement-phase1`

It's all my commits. I reuse my branch for this extension. git checkout -b newbranch can have a clean commit history. File changed tab only shows changes compared to master. It's not an obstacle for readers.

@qwordy qwordy merged commit 9796d83 into Azure:master Apr 7, 2020
ManuInNZ pushed a commit to ManuInNZ/azure-cli-extensions that referenced this pull request Apr 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants