spring-cloud: add location to Apps operation#1458
spring-cloud: add location to Apps operation#1458fengzhou-msft merged 6 commits intoAzure:masterfrom xgugeng:hkn/spring-app-location
Conversation
|
If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR: |
|
add to S168 |
| logger.warning("[1/2] updating app '{}'".format(name)) | ||
| poller = client.apps.update( | ||
| resource_group, service, name, properties) | ||
| resource_group, service, name, properties, location) |
There was a problem hiding this comment.
why location required in each rest call. suppose it should not in update parameter in swagger
There was a problem hiding this comment.
We are migrating Microsoft.AppPlatform/Spring/Apps from proxy resource to tracked resource. And location is a must for tracked resource. I've also updated the swagger change in Azure/azure-rest-api-specs#8851
There was a problem hiding this comment.
If this location is always the same as the location of the resource_group, why not fetch it from the resource group on the service side? Or location could be different in the future?
There was a problem hiding this comment.
Not the same with the location of resource_group, but with the one of Microsoft.AppPlatform/Spring. We cannot do it on service side, since it's ARM consuming this property, before our RP.
There was a problem hiding this comment.
I see. Thanks for the explanation.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json.