{omsagent} role assignment changes for msi (#1)#1258
Merged
mmyyrroonn merged 20 commits intoAzure:masterfrom Feb 24, 2020
Merged
{omsagent} role assignment changes for msi (#1)#1258mmyyrroonn merged 20 commits intoAzure:masterfrom
mmyyrroonn merged 20 commits intoAzure:masterfrom
Conversation
|
If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR: |
Collaborator
|
add to S165. |
* {omsagent} role assignment changes for msi
mmyyrroonn
approved these changes
Feb 20, 2020
Contributor
mmyyrroonn
left a comment
There was a problem hiding this comment.
Hello. Like we talked offline, could you change the help message in extension too? Better to have same code with the main azure cli
Contributor
Author
I have added the changes in the help too |
mmyyrroonn
approved these changes
Feb 24, 2020
Contributor
mmyyrroonn
left a comment
There was a problem hiding this comment.
Same with this one. Azure/azure-cli#12100 (review) LGTM. Could you please update the index.json in the same PR?
ManuInNZ
pushed a commit
to ManuInNZ/azure-cli-extensions
that referenced
this pull request
Apr 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Role assignment changes to assign role for msi if it is created for omsagent addon