Conversation
|
If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR: |
b708213 to
5eeeb00
Compare
jiasli
reviewed
Oct 31, 2019
| "downloadUrl": "https://azurecliprod.blob.core.windows.net/cli-extensions/spring_cloud-0.1.0-py2.py3-none-any.whl", | ||
| "filename": "spring_cloud-0.1.0-py2.py3-none-any.whl", | ||
| "metadata": { | ||
| "classifiers": [ |
Member
There was a problem hiding this comment.
No "azext.minCliCoreVersion": "2.0.46" needed here?
jiasli
reviewed
Oct 31, 2019
| packages=find_packages(), | ||
| install_requires=DEPENDENCIES, | ||
| package_data={'azext_spring-cloud': ['azext_metadata.json']}, | ||
| package_data={'azext_spring_cloud': ['azext_metadata.json']}, |
Member
There was a problem hiding this comment.
Looks like this ext is also using -. Which one is correct?
jiasli
approved these changes
Oct 31, 2019
Member
|
We can merge for now. But the |
ManuInNZ
pushed a commit
to ManuInNZ/azure-cli-extensions
that referenced
this pull request
Apr 11, 2020
* new index * new spring-cloud index * removed index * another index * regenerated index again * fixed metadata * fixed metadata?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions: