Skip to content

Spring cloud bug fix#1045

Merged
zikalino merged 6 commits intoAzure:masterfrom
VSChina:peizhou/SpringCloudRebase
Oct 31, 2019
Merged

Spring cloud bug fix#1045
zikalino merged 6 commits intoAzure:masterfrom
VSChina:peizhou/SpringCloudRebase

Conversation

@peizhou298
Copy link
Copy Markdown
Contributor

@peizhou298 peizhou298 commented Oct 31, 2019 •
edited
Loading

…c to async

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

@azuresdkci
Copy link
Copy Markdown

azuresdkci commented Oct 31, 2019

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:

docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/VSChina/azure-cli-extensions.git@peizhou/SpringCloudRebase#subdirectory=src/$EXT&egg=$EXT"

@peizhou298 peizhou298 requested a review from zikalino as a code owner October 31, 2019 06:27
yuwzho
yuwzho reviewed Oct 31, 2019
View reviewed changes
@zikalino zikalino merged commit 4e2fa24 into Azure:master Oct 31, 2019
@zikalino zikalino deleted the peizhou/SpringCloudRebase branch October 31, 2019 08:12
ManuInNZ pushed a commit to ManuInNZ/azure-cli-extensions that referenced this pull request Apr 11, 2020
@peizhou298 @ManuInNZ
Spring cloud bug fix (Azure#1045)
20ee6de 
* use poller waiting for app create/update because sdk changed from sync to async

* remove spring-cloud in index.json

* make app update and deployment create parallel when creating app

* fix CI issues

* fix null error in app table transformer

* use is None to judge null
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@zikalino zikalino zikalino approved these changes

@yuwzho yuwzho yuwzho approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@peizhou298 @azuresdkci @zikalino @yuwzho