Skip to content

Docker migration#1043

Merged
fengzhou-msft merged 3 commits intoAzure:masterfrom
fengzhou-msft:docker_migration
Oct 31, 2019
Merged

Docker migration#1043
fengzhou-msft merged 3 commits intoAzure:masterfrom
fengzhou-msft:docker_migration

Conversation

@fengzhou-msft
Copy link
Copy Markdown
Member

@fengzhou-msft fengzhou-msft commented Oct 31, 2019

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

@azuresdkci
Copy link
Copy Markdown

azuresdkci commented Oct 31, 2019

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:

docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/fengzhou-msft/azure-cli-extensions.git@docker_migration#subdirectory=src/$EXT&egg=$EXT"

@fengzhou-msft fengzhou-msft merged commit a453cf4 into Azure:master Oct 31, 2019
ManuInNZ pushed a commit to ManuInNZ/azure-cli-extensions that referenced this pull request Apr 11, 2020
@fengzhou-msft @ManuInNZ
Docker migration (Azure#1043)
4e582d2 
* docker change

* change docker image name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@zikalino zikalino zikalino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fengzhou-msft @azuresdkci @zikalino