Skip to content

az connectedmachine extension#1031

Merged
zikalino merged 7 commits intoAzure:masterfrom
farehar:master
Oct 30, 2019
Merged

az connectedmachine extension#1031
zikalino merged 7 commits intoAzure:masterfrom
farehar:master

Conversation

@farehar
Copy link
Copy Markdown
Contributor

@farehar farehar commented Oct 30, 2019

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

@azuresdkci
Copy link
Copy Markdown

azuresdkci commented Oct 30, 2019

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:

docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/farehar/azure-cli-extensions.git@master#subdirectory=src/$EXT&egg=$EXT"

zikalino
zikalino reviewed Oct 30, 2019
View reviewed changes
src/connectedmachine/azext_connectedmachine/_params.py Outdated
from azure.cli.core.commands.parameters import tags_type
from azure.cli.core.commands.validators import get_default_location_from_resource_group

name_type = CLIArgumentType(options_list='--name-name', help='Name of the Connected machine.', id_part='name')
Copy link
Copy Markdown

@zikalino zikalino Oct 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't be just --name?

Copy link
Copy Markdown
Contributor Author

@farehar farehar Oct 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. updated

@zikalino zikalino merged commit 033ea4e into Azure:master Oct 30, 2019
ManuInNZ pushed a commit to ManuInNZ/azure-cli-extensions that referenced this pull request Apr 11, 2020
@farehar @ManuInNZ
az connectedmachine extension (Azure#1031)
b0b33da 
* Az cli extension for connected machines

* add code owners

* add code owners

* update name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@zikalino zikalino zikalino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@farehar @azuresdkci @zikalino