Skip to content

Minor bug fix related to cluster auto scaler#1014

Merged
zikalino merged 2 commits intoAzure:masterfrom
xizha162:xizha-cafix
Oct 28, 2019
Merged

Minor bug fix related to cluster auto scaler#1014
zikalino merged 2 commits intoAzure:masterfrom
xizha162:xizha-cafix

Conversation

@xizha162
Copy link
Copy Markdown
Contributor

Minor bug fix to allow autoscaler changes when there is only ONE node pool. Also, in the scale case, if customer provided the nodepool name, will scale that node pool


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

@xizha162 xizha162 requested a review from zqingqing1 as a code owner October 24, 2019 20:57
@azuresdkci
Copy link
Copy Markdown

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:

docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/xizhamsft/azure-cli-extensions.git@xizha-cafix#subdirectory=src/$EXT&egg=$EXT"

Copy link
Copy Markdown
Contributor

@marwanad marwanad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes LGTM

Copy link
Copy Markdown
Member

@zqingqing1 zqingqing1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zikalino zikalino merged commit ad20bd9 into Azure:master Oct 28, 2019
ManuInNZ pushed a commit to ManuInNZ/azure-cli-extensions that referenced this pull request Apr 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants