Skip to content

update cli to use 2019-10-01#1010

Merged
zikalino merged 3 commits intoAzure:masterfrom
weinong:v20191001
Oct 25, 2019
Merged

update cli to use 2019-10-01#1010
zikalino merged 3 commits intoAzure:masterfrom
weinong:v20191001

Conversation

@weinong
Copy link
Copy Markdown
Contributor

@weinong weinong commented Oct 22, 2019

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

@azuresdkci
Copy link
Copy Markdown

azuresdkci commented Oct 22, 2019

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:

docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/weinong/azure-cli-extensions.git@v20191001#subdirectory=src/$EXT&egg=$EXT"

feiskyer
feiskyer approved these changes Oct 23, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zqingqing1
zqingqing1 approved these changes Oct 23, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@zqingqing1 zqingqing1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@weinong
Copy link
Copy Markdown
Contributor Author

weinong commented Oct 23, 2019

@zikalino PTAL

@zikalino zikalino merged commit 4b51313 into Azure:master Oct 25, 2019
ManuInNZ pushed a commit to ManuInNZ/azure-cli-extensions that referenced this pull request Apr 11, 2020
@weinong @ManuInNZ
update cli to use 2019-10-01 (Azure#1010)
128c7e9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@feiskyer feiskyer feiskyer approved these changes

+2 more reviewers

@zikalino zikalino zikalino approved these changes

@zqingqing1 zqingqing1 zqingqing1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@weinong @azuresdkci @feiskyer @zikalino @zqingqing1