Add spring-cloud extension#1001
Merged
zikalino merged 76 commits intoAzure:masterfrom Oct 28, 2019
VSChina:peizhou/ChangeExtensionName
Merged
Add spring-cloud extension#1001zikalino merged 76 commits intoAzure:masterfrom VSChina:peizhou/ChangeExtensionName
zikalino merged 76 commits intoAzure:masterfrom
VSChina:peizhou/ChangeExtensionName
Conversation
fix wording in custom.py
Fix wording and add app list query example
Collaborator
|
@zikalino can help with review. |
zikalino
reviewed
Oct 24, 2019
src/spring-cloud/setup.py
Outdated
| ] | ||
|
|
||
| # TODO: Add any additional SDK dependencies here | ||
| DEPENDENCIES = [ |
There was a problem hiding this comment.
just leave it empty [] otherwise it will cause problem with release
Contributor
Author
There was a problem hiding this comment.
Fixed alrady, remove 'azure-cli-core' int dependencies.
…ina/azure-cli-extensions into peizhou/ChangeExtensionName
…log when deployment is Jar type
zikalino
reviewed
Oct 25, 2019
|
|
||
| rule.match_conditions.append(MatchCondition( | ||
| match_variable=match_variable, | ||
| selector=selector, |
There was a problem hiding this comment.
I know this is only whitespace, but could we just somehow revert it?
Contributor
Author
There was a problem hiding this comment.
Sure, wired thing is I copy the source text from main branch but still get this problem, let me double fix.
|
are you planning to replace SDK with newest version? |
…ina/azure-cli-extensions into peizhou/ChangeExtensionName
Contributor
Author
|
|
If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR: |
Contributor
Author
|
Reopen. |
zikalino
approved these changes
Oct 28, 2019
ManuInNZ
pushed a commit
to ManuInNZ/azure-cli-extensions
that referenced
this pull request
Apr 11, 2020
* add spring cloud service * fix help and params syntax error * use relative path instead of file name when upload file * add service binding * use autopep8 format code * change binding cosmosdb update function * didn't remove app when create app failed * use nginx image for app default deployment * fix wording in custom.py * use latest sdk * use new version * remove mvnw mvn in * change app create behavior * show deployment when show app * add test-endpoint command * remove redundant print * fix validate key syntax error * change namespace to appplatform * change default deployment name to default * change extension from asc to spring-cloud * fix test-endpoint list format * fix some prompt information * Update _help.py * Update _params.py * Update _help.py * Update custom.py * add config server git command group * remove tags in deployment create/deploy * use resource-group's location when creating service if not specified * remove extra test * set app update cpu, memory,count to None to avoid default value * add skip clone settings * fix config server none type bugs * fix deployment help errors * CLI review change * add prompt for after successfully upload jar package * add spring cloud in index.json and use blob url * check config server null before get it's inside property * update index.json for spring-cloud * use sdk's enum type * convert lcoation from display name to proper name * update index.json * update index.json * format table output * remove reduent None juge * remove spring-cloud in index.json * format code with autopep8 * fix style check error * replace old sdk with new sdk from offical repo * fix CI check warnings * disable worng import error check * add code owners for spring-cloud * code owners * CI: add missed liscense headers * add runtime-version, jvm-options and env settings in app create * remove unnecessary changes outside spring-cloud * remove upper limit of cli core version * add upper Azure cli version 2.1.0 and raise exception in show-deploy-log when deployment is Jar type * use new Python sdk * Remove extra changes out-side spring-cloud * add new line int fronnt door customer.py * fronnt-door * Update custom.py * Update custom.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions: