Refactor and remove a custom way of getting subscriptions#1000
Merged
zikalino merged 4 commits intoAzure:masterfrom Oct 28, 2019
Merged
Refactor and remove a custom way of getting subscriptions#1000zikalino merged 4 commits intoAzure:masterfrom
zikalino merged 4 commits intoAzure:masterfrom
Conversation
The same thing has been done for azure-cli: Azure/azure-cli#10111
|
If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR: |
Member
Author
|
@zqingqing1 can you please have a review? |
Member
Author
|
@zikalino could you please help review and merge the PR? Thanks! |
zikalino
approved these changes
Oct 28, 2019
ManuInNZ
pushed a commit
to ManuInNZ/azure-cli-extensions
that referenced
this pull request
Apr 11, 2020
* Refactor and remove a custom way of getting subscriptions The same thing has been done for azure-cli: Azure/azure-cli#10111 * remove unused-import * Add missing line
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The same thing has been done to azure-cli.
Azure/azure-cli#10111
The issue this PR can fix:
Actual: The Log Analytics Default Workspace is created in subscription A.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?