[ACS] Fix the SPN Insufficient Permission Issue for Virtual Kubelet installed by aks install-connector#5583
Merged
tjprescott merged 4 commits intoAzure:devfrom Feb 15, 2018
Merged
Conversation
|
View a preview at https://prompt.ws/r/Azure/azure-cli/5583 |
mboersma
reviewed
Feb 14, 2018
|
|
||
| 2.0.27 | ||
| ++++++ | ||
| * use the virtual-kubelet-for-aks helm chart for `aks install-connector` by default, and fix the service principal insufficient permission to create ACI container group issue |
Member
There was a problem hiding this comment.
Could you separate this into two bullet points?
| short-summary: Service principal used for authentication to Azure APIs. | ||
| long-summary: If not specified, a new service principal is created and cached at | ||
| {sp_cache} to be used by subsequent `az aks` commands. | ||
| long-summary: If not specified, use the AKS service principal defined in the file |
| ",env.nodeName=" + node_name + ",env.nodeTaint=" + node_taint + ",env.nodeOsType=" + os_type]) | ||
| values = "image.tag={},env.nodeName={},env.nodeTaint={},env.nodeOsType={}".format(image_tag, node_name, node_taint, os_type) # pylint: disable=line-too-long | ||
|
|
||
| if service_principal is not None: |
Member
There was a problem hiding this comment.
Would this be better as just
if not service_principal:That's the pythonic way, unless we specifically want identity comparison with None here.
Contributor
Author
There was a problem hiding this comment.
do you mean
if service_principal:
Member
There was a problem hiding this comment.
D'oh yes of course that's what I meant.
mboersma
approved these changes
Feb 15, 2018
tjprescott
approved these changes
Feb 15, 2018
LukaszStem
pushed a commit
to LukaszStem/azure-cli
that referenced
this pull request
Feb 21, 2018
…nstalled by `aks install-connector` (Azure#5583) * Fix the SPN Permission Issue for ACI Connector (Virtual-Kubelet) * Update HISTORY.rst * Increase the module version for acs * Incorporate feedbacks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Command Guidelines
(see Authoring Command Modules)