[Container] Add secrets for container instances#5578
Merged
tjprescott merged 7 commits intoAzure:devfrom Feb 20, 2018
Merged
Conversation
Adds --secrets and --secrets-mount-path to add secrets for an Azure Container Instance.
|
View a preview at https://prompt.ws/r/Azure/azure-cli/5578 |
derekbekoe
reviewed
Feb 14, 2018
Member
derekbekoe
left a comment
There was a problem hiding this comment.
Fix typo in release notes but LGTM otherwise.
|
|
||
| 0.1.19 | ||
| ++++++ | ||
| * Add '--secrets' and '--secrets-mount-path' options to 'az container create' for usgin secrets in ACI |
Member
Author
|
Thanks @derekbekoe, I fixed the typo |
Member
Author
|
Now fixing some tests... |
Member
Author
|
Fixed a type, a pylint issue and re-recorded the test. Please review. |
tjprescott
reviewed
Feb 15, 2018
Member
tjprescott
left a comment
There was a problem hiding this comment.
A question but otherwise LGTM
| secrets_type = CLIArgumentType( | ||
| validator=validate_secrets, | ||
| help="space-separated secrets in 'key=value' format.", | ||
| nargs='*' |
Member
There was a problem hiding this comment.
nargs='*' means it takes 0 or more arguments. Is this what you intended? 1 or more is nargs='+'
Member
Author
There was a problem hiding this comment.
Good catch, I think that + makes more sense. I was 'inspired' by the --tags pattern, but that has a valid use case for 'empty' tags array.
Pending...
tjprescott
approved these changes
Feb 20, 2018
LukaszStem
pushed a commit
to LukaszStem/azure-cli
that referenced
this pull request
Feb 21, 2018
* Add secrets for container instances Adds --secrets and --secrets-mount-path to add secrets for an Azure Container Instance. * Version 0.1.19 * fixup! Add secrets for container instances * fixup! Version 0.1.19 * fixup! Add secrets for container instances * fixup! Add secrets for container instances * Do not allow empty array of secrets
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add secrets for container instances on create/update.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Command Guidelines
(see Authoring Command Modules)