Fixes#5538: list_locations supports 'Free' and 'shared' as valid parameters#5552
Conversation
|
View a preview at https://prompt.ws/r/Azure/azure-cli/5552 |
| ++++++ | ||
| * webapp backup/restore: Fix issue where restore command fails because of a null reference | ||
| * appservice: support default app service plan through `az configure --defaults appserviceplan=my-asp` | ||
| * appservice: list-location: reports Free as an invalid SKU |
There was a problem hiding this comment.
This should be in the new version section, the current version will be released tomorrow.
Also the text should reflect what is being fixed, e.g. fix the bug that reports Free as an invalid SKU
There was a problem hiding this comment.
@yugangw-msft & @tjprescott , i will make the change move to new version & update history. However, there is no existing test for list-locations, since this returns a list of locations from the API, & that is not a static list - so can we just check the response is 200, specifically for Free SKU? Let me know. Thanks!
There was a problem hiding this comment.
You can verify the response is the same as from F1
tjprescott
left a comment
There was a problem hiding this comment.
This should be added to a new or existing test.
| =============== | ||
| 0.1.27 | ||
| ++++++ | ||
| * appservice: list-location: reports Free as an invalid SKU |
There was a problem hiding this comment.
I thought this change actually fixes the issue where it reports Free as invalid.
This note makes it seem like now it will report Free as invalid.
Fixes #5538
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Command Guidelines
(see Authoring Command Modules)