Skip to content

Convert storage batch operation tests.#3190

Merged
troydai merged 5 commits intoAzure:masterfrom
troydai:fix.storage.tests
May 8, 2017
Merged

Convert storage batch operation tests.#3190
troydai merged 5 commits intoAzure:masterfrom
troydai:fix.storage.tests

Conversation

@troydai
Copy link
Copy Markdown
Contributor

@troydai troydai commented May 5, 2017

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • The PR has modified HISTORY.rst with an appropriate description of the change (see Modifying change log).

Command Guidelines

  • Each command and parameter has a meaningful description.
  • Each new command has a test.

(see Authoring Command Modules)

@troydai troydai requested a review from tjprescott May 5, 2017 20:41
@codecov-io
Copy link
Copy Markdown

codecov-io commented May 5, 2017

Codecov Report

Merging #3190 into master will increase coverage by <.01%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3190      +/-   ##
==========================================
+ Coverage   70.34%   70.35%   +<.01%     
==========================================
  Files         383      381       -2     
  Lines       24960    24778     -182     
  Branches     3797     3785      -12     
==========================================
- Hits        17558    17432     -126     
+ Misses       6291     6237      -54     
+ Partials     1111     1109       -2
Impacted Files Coverage Δ
...c/azure-cli-testsdk/azure/cli/testsdk/preparers.py 69.17% <80%> (+0.23%) ⬆️
...ules/azure-cli-interactive/azclishell/argfinder.py 34.78% <0%> (-2.72%) ⬇️
...li-core/azure/cli/core/test_utils/vcr_test_base.py 69.18% <0%> (-0.98%) ⬇️
...modules/azure-cli-interactive/azclishell/layout.py 43.15% <0%> (-0.85%) ⬇️
src/azure-cli-core/azure/cli/core/application.py 89.42% <0%> (-0.25%) ⬇️
...s/azure-cli-interactive/azclishell/az_completer.py 60.59% <0%> (-0.2%) ⬇️
src/azure-cli-testsdk/azure/cli/testsdk/base.py 69.69% <0%> (-0.16%) ⬇️
...azure-cli-core/azure/cli/core/commands/__init__.py 84.31% <0%> (-0.03%) ⬇️
...zure-cli-interactive/azclishell/gather_commands.py 37.71% <0%> (ø) ⬆️
...dules/azure-cli-interactive/azclishell/progress.py
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cd1931...a4b3e8e. Read the comment docs.

tjprescott
tjprescott approved these changes May 8, 2017
View reviewed changes
Copy link
Copy Markdown
Member

@tjprescott tjprescott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. :)

@troydai troydai merged commit f40f3d0 into Azure:master May 8, 2017
@troydai troydai deleted the fix.storage.tests branch May 8, 2017 16:35
@troydai
Copy link
Copy Markdown
Contributor Author

troydai commented May 8, 2017

thanks.

00Kai0 pushed a commit to 00Kai0/azure-cli that referenced this pull request Apr 7, 2021
@j-so
[azure-cli-ml] Update version to 1.25.0 (Azure#3190)
184cdc3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@tjprescott tjprescott tjprescott approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla-not-required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@troydai @codecov-io @tjprescott @msftclas @haroldrandom