role: fix role definition update and accept custom password on create SP#2845
Merged
yugangw-msft merged 4 commits intoAzure:masterfrom Apr 13, 2017
Merged
role: fix role definition update and accept custom password on create SP#2845yugangw-msft merged 4 commits intoAzure:masterfrom
yugangw-msft merged 4 commits intoAzure:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2845 +/- ##
==========================================
+ Coverage 62.92% 63.11% +0.18%
==========================================
Files 464 464
Lines 25899 25914 +15
Branches 3943 3947 +4
==========================================
+ Hits 16298 16355 +57
+ Misses 8567 8509 -58
- Partials 1034 1050 +16
Continue to review full report at Codecov.
|
troydai
approved these changes
Apr 13, 2017
|
Thank you for the quick turn around. |
00Kai0
pushed a commit
to 00Kai0/azure-cli
that referenced
this pull request
Apr 7, 2021
…2845) Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_ID=668394 Last commit: Azure/azure-cli-extensions@b03a024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #2745
I gave a thought and decided to let update be consistent with the create, and both will use the same role definition file. I put in the logic in
updateto handle both logic name and real name. The difference between these 2 names are rather confusing and we should not surface those to users.All new logics are covered by the new unit tests. VCR based tests are discouraged as role definition service has serious server replicate issue and I waited up to 10 minutes to have one new definition be available in all servers.
General Guidelines
Command Guidelines
(see Authoring Command Modules)