Skip to content

Improve az find search results#2828

Merged
devigned merged 2 commits intoAzure:masterfrom
devigned:bug/find
Apr 11, 2017
Merged

Improve az find search results#2828
devigned merged 2 commits intoAzure:masterfrom
devigned:bug/find

Conversation

@devigned
Copy link
Copy Markdown
Member

@devigned devigned commented Apr 11, 2017

Fixes #2805

$ az find -q keyvault list
`az keyvault list`
    List key vaults.

`az keyvault key list`
    List keys in the specified vault.

`az keyvault certificate list`
    List certificates in the specified vault.

`az keyvault secret list`
    List secrets in the specified vault.

`az keyvault certificate list-versions`
    List the versions of a certificate.

`az keyvault secret list-versions`
    List the versions of the specified secret.

`az keyvault key list-versions`
    List the versions of the specified key.

`az keyvault certificate issuer list`
    List certificate issuers for the specified vault.

`az keyvault certificate issuer admin list`
    List admins for a specified certificate issuer.

`az keyvault certificate contact list`
    Gets the certificate contacts for the specified vault.

@devigned devigned requested a review from yugangw-msft April 11, 2017 18:42
yugangw-msft
yugangw-msft reviewed Apr 11, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@yugangw-msft yugangw-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the test to ensure we don't see vm/resource/vnet list when search for keyvault list,or at least they should appear at bottom.
Also get CI pass

@codecov-io
Copy link
Copy Markdown

codecov-io commented Apr 11, 2017 •
edited
Loading

Codecov Report

Merging #2828 into master will decrease coverage by <.01%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2828      +/-   ##
==========================================
- Coverage   62.88%   62.88%   -0.01%     
==========================================
  Files         464      464              
  Lines       25890    25901      +11     
  Branches     3944     3945       +1     
==========================================
+ Hits        16281    16287       +6     
- Misses       8590     8594       +4     
- Partials     1019     1020       +1
Impacted Files Coverage Δ
...-cli-find/azure/cli/command_modules/find/custom.py 88% <83.33%> (-5.75%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4769d93...e97639f. Read the comment docs.

@devigned
Copy link
Copy Markdown
Member Author

devigned commented Apr 11, 2017

@yugangw-msft if you want more robust test, then I would leave it the way it is. keyvault list is shown, but it by no means precludes resource list from showing if some of the keyvault commands are changed. Those commands have list in the name, thus will score relatively well, but not as well as items with keyvault and list in the name.

@devigned
Copy link
Copy Markdown
Member Author

devigned commented Apr 11, 2017

@yugangw-msft I updated based on your advice to check for az keyvault list in the test.

@devigned devigned merged commit bb1e0d9 into Azure:master Apr 11, 2017
@devigned devigned deleted the bug/find branch April 11, 2017 23:11
00Kai0 pushed a commit to 00Kai0/azure-cli that referenced this pull request Apr 7, 2021
@levimm
bump to 0.4.71 for private dns zone feature (Azure#2828)
9b7abd5 
Co-authored-by: Li Ma <lima2@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@yugangw-msft yugangw-msft yugangw-msft approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla-not-required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@devigned @codecov-io @yugangw-msft @msftclas @haroldrandom