ACS: remove the old smart create templates and a few more improvements#2801
ACS: remove the old smart create templates and a few more improvements#2801tjprescott merged 7 commits intoAzure:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2801 +/- ##
==========================================
- Coverage 62.89% 62.84% -0.06%
==========================================
Files 480 463 -17
Lines 26012 25822 -190
Branches 3946 3932 -14
==========================================
- Hits 16361 16227 -134
+ Misses 8627 8581 -46
+ Partials 1024 1014 -10
Continue to review full report at Codecov.
|
tjprescott
left a comment
There was a problem hiding this comment.
LGTM. These FC -> ARM refactorings rely heavily on the fact that the test scenarios have to be re-recorded. If @brendandburns is satisfied that the tests cover the relevant scenarios, then I'm good. If not, we probably need to beef up the scenario test coverage to ensure this doesn't introduce regressions.
|
@brendandburns, the |
tjprescott
left a comment
There was a problem hiding this comment.
Thanks for adding the second scenario test. LGTM. Bye bye "smart create"!
//cc: @brendandburns
Some addition change
--no-waitargument andaz acs waitcommand--validatefor dry-run test and you can use '--verbose' to see the full templageThis checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Command Guidelines
[] Each command and parameter has a meaningful description.[] Each new command has a test.(see Authoring Command Modules)