Skip to content

[Network] Convert Load Balancer and App Gateway Create to Dynamic Templates#2668

Merged
tjprescott merged 10 commits intoAzure:masterfrom
tjprescott:ConvertAGCreate
Mar 30, 2017
Merged

[Network] Convert Load Balancer and App Gateway Create to Dynamic Templates#2668
tjprescott merged 10 commits intoAzure:masterfrom
tjprescott:ConvertAGCreate

Conversation

@tjprescott
Copy link
Copy Markdown
Member

@tjprescott tjprescott commented Mar 29, 2017

Closes #2198.

@tjprescott tjprescott added the Network az network vnet/lb/nic/dns/etc... label Mar 29, 2017
@tjprescott tjprescott requested a review from yugangw-msft March 29, 2017 21:19
@tjprescott tjprescott mentioned this pull request Mar 29, 2017
Closed
10 tasks
yugangw-msft
yugangw-msft reviewed Mar 29, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@yugangw-msft yugangw-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM.

src/command_modules/azure-cli-network/azure/cli/command_modules/network/_params.py Outdated
Copy link
Copy Markdown
Contributor

@yugangw-msft yugangw-msft Mar 29, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears a dupe with the same declaration 8 lines above

src/command_modules/azure-cli-network/azure/cli/command_modules/network/_params.py Outdated
Copy link
Copy Markdown
Contributor

@yugangw-msft yugangw-msft Mar 29, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dupe with the same one 2 lines above?

src/command_modules/azure-cli-network/azure/cli/command_modules/network/custom.py Outdated
Copy link
Copy Markdown
Contributor

@yugangw-msft yugangw-msft Mar 29, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can consider to reuse https://github.com/Azure/azure-cli/blob/master/src/command_modules/azure-cli-vm/azure/cli/command_modules/vm/_vm_utils.py#L49

@codecov-io
Copy link
Copy Markdown

codecov-io commented Mar 30, 2017 •
edited
Loading

Codecov Report

Merging #2668 into master will decrease coverage by 0.33%.
The diff coverage is 86.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2668      +/-   ##
==========================================
- Coverage   61.48%   61.14%   -0.34%     
==========================================
  Files         514      480      -34     
  Lines       26019    25673     -346     
  Branches     3898     3883      -15     
==========================================
- Hits        15997    15698     -299     
+ Misses       9079     9048      -31     
+ Partials      943      927      -16
Impacted Files Coverage Δ
...ure/cli/command_modules/network/_client_factory.py 95.16% <ø> (-0.56%) ⬇️
...twork/azure/cli/command_modules/network/_params.py 92.53% <100%> (+0.16%) ⬆️
...work/azure/cli/command_modules/network/commands.py 98.98% <100%> (ø) ⬆️
...k/azure/cli/command_modules/network/_validators.py 63.63% <75%> (-0.17%) ⬇️
...etwork/azure/cli/command_modules/network/custom.py 62.83% <79.76%> (+1.2%) ⬆️
...e/cli/command_modules/network/_template_builder.py 84.04% <90.74%> (+11.54%) ⬆️
...cli-core/azure/cli/core/commands/client_factory.py 86.11% <0%> (ø) ⬆️
...ource/azure/cli/command_modules/resource/custom.py 55.1% <0%> (+0.49%) ⬆️
...-cli-role/azure/cli/command_modules/role/custom.py 19.47% <0%> (+1.57%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c343c36...590fe57. Read the comment docs.

@tjprescott
Copy link
Copy Markdown
Member Author

tjprescott commented Mar 30, 2017

@yugangw-msft comments addressed.

@tjprescott tjprescott merged commit 2f0cb9d into Azure:master Mar 30, 2017
@tjprescott tjprescott deleted the ConvertAGCreate branch March 30, 2017 18:00
@haroldrandom haroldrandom added cla-not-required Network az network vnet/lb/nic/dns/etc... labels Oct 25, 2019
00Kai0 pushed a commit to 00Kai0/azure-cli that referenced this pull request Apr 7, 2021
[Release] Update index.json for extension [ vm-repair ] (Azure#2668)
3d7d29c 
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_ID=618365

Last commit: Azure/azure-cli-extensions@99130c4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@yugangw-msft yugangw-msft yugangw-msft approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla-not-required Network az network vnet/lb/nic/dns/etc...

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tjprescott @codecov-io @yugangw-msft @msftclas @haroldrandom