[EventHub] `az eventhubs namespace application-group policy remove`: Add upcoming breaking change notification by schaudhari6254888 · Pull Request #26041 · Azure/azure-cli

schaudhari6254888 · 2023-04-04T06:56:04Z

Related command
az eventhubs namespace application-group policy remove

Description
Removing parameters metric-id, rate-limit-threshold from --throttling-policy-config object only for az eventhubs namespace application-group policy remove command.
Additionally changing throttling-policy-config name to policy, for az eventhubs namespace application-group policy remove command.
The change will release in Upcoming breaking change cycle i.e May.

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change
[Component Name 2] az command b: Add some customer-facing feature

This checklist is used to make sure that common guidelines for a pull request are followed.

The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.

azure-client-tools-bot-prd · 2023-04-04T06:56:08Z

️✔️acr

️✔️acs

️✔️advisor

️✔️ams

️✔️apim

️✔️appconfig

️✔️appservice

️✔️aro

️✔️backup

️✔️batch

️✔️batchai

️✔️billing

️✔️botservice

️✔️cdn

️✔️cloud

️✔️cognitiveservices

️✔️config

️✔️configure

️✔️consumption

️✔️container

️✔️core

️✔️cosmosdb

️✔️databoxedge

️✔️dla

️✔️dls

️✔️dms

️✔️eventgrid

️✔️eventhubs

️✔️feedback

️✔️find

️✔️hdinsight

️✔️identity

️✔️iot

️✔️keyvault

️✔️kusto

️✔️lab

️✔️managedservices

️✔️maps

️✔️marketplaceordering

️✔️monitor

️✔️netappfiles

️✔️network

️✔️policyinsights

️✔️privatedns

️✔️profile

️✔️rdbms

️✔️redis

️✔️relay

️✔️resource

️✔️role

️✔️search

️✔️security

️✔️servicebus

️✔️serviceconnector

️✔️servicefabric

️✔️signalr

️✔️sql

️✔️sqlvm

️✔️storage

️✔️synapse

️✔️telemetry

️✔️util

️✔️vm

yonzhan · 2023-04-04T06:56:17Z

EventHub

src/azure-cli/azure/cli/command_modules/eventhubs/custom.py

schaudhari6254888 · 2023-04-10T10:48:44Z

Can someone please review & merge this pull request. Only contain the breaking change alert message

src/azure-cli/azure/cli/command_modules/eventhubs/custom.py

evelyn-ys · 2023-04-11T02:09:31Z

If the "breaking change" you mentioned is "metric-id,rate-limit-threshold would not be required", then I don't think it breaks anything. So you can just modify the title & description with Add warning for balabala

Co-authored-by: Yishi Wang <yishiwang@microsoft.com>

schaudhari6254888 · 2023-04-11T08:32:14Z

Since we are using this parameters while removing the policy name previously.
but in future release i.e cli migration, we are deprecating it from remove command, So I think this is breaking change.

evelyn-ys · 2023-04-11T09:46:26Z

When will you deprecate these parameters? The code change seems nothing to do with the breaking change...

Just FYI, CLI only allows breaking change twice a year and next breaking change window is May release

schaudhari6254888 · 2023-04-11T09:51:20Z

Inside the --throttling-policy-config object these parameters are present for removal policy.
In future these 2 parameters are not needed for deletion.
I want to do this change in this "breaking change cycle" only.

evelyn-ys · 2023-04-11T10:46:30Z

So this PR is not related with this breaking change, right? Can you modify the PR title and description?

schaudhari6254888 · 2023-04-11T10:51:38Z

This PR, I am only giving Message notification.

evelyn-ys · 2023-04-12T05:38:28Z

src/azure-cli/azure/cli/command_modules/eventhubs/custom.py

    appGroup = client.get(resource_group_name, namespace_name, application_group_name)
-
+    logger.warning(
+        'This operation will do removals based on policy name')


I don't think with this message customers are able to realize there will be breaking change in the future......

It just says policy name will be used for removals

If you want to notify that you won't accept metric-id,rate-limit-threshold in the future, pls say it explicitly

Hey @evelyn-ys , Sorry for the inconvenience.
Does the Description & warning message makes the good sense now?
Any suggestions are always welcome.

…Add upcoming breaking change notification (Azure#26041) * Breaking change * updates * CI's fixed * Update src/azure-cli/azure/cli/command_modules/eventhubs/custom.py Co-authored-by: Yishi Wang <yishiwang@microsoft.com> * Updates * Updates --------- Co-authored-by: Yishi Wang <yishiwang@microsoft.com>

Breaking change

29bd456

azure-client-tools-bot-prd bot added this to the April 2023 (2023-04-25) milestone Apr 4, 2023

ghost added Auto-Assign Auto assign by bot Event Hubs az eventhubs labels Apr 4, 2023

ghost requested a review from evelyn-ys April 4, 2023 06:56

ghost requested a review from calvinhzy April 4, 2023 06:56

ghost assigned evelyn-ys Apr 4, 2023

ghost requested a review from yonzhan April 4, 2023 06:56

damodaravadhani reviewed Apr 4, 2023

View reviewed changes

src/azure-cli/azure/cli/command_modules/eventhubs/custom.py Outdated Show resolved Hide resolved

schaudhari6254888 added 2 commits April 4, 2023 12:36

updates

5219bbb

CI's fixed

16ac11f

schaudhari6254888 marked this pull request as ready for review April 4, 2023 09:36

evelyn-ys reviewed Apr 11, 2023

View reviewed changes

src/azure-cli/azure/cli/command_modules/eventhubs/custom.py Outdated Show resolved Hide resolved

Update src/azure-cli/azure/cli/command_modules/eventhubs/custom.py

e745ee4

Co-authored-by: Yishi Wang <yishiwang@microsoft.com>

evelyn-ys reviewed Apr 12, 2023

View reviewed changes

schaudhari6254888 added 2 commits April 12, 2023 15:39

Updates

7c82006

Updates

cc040ad

evelyn-ys approved these changes Apr 13, 2023

View reviewed changes

evelyn-ys changed the title ~~[EventHub] Add breaking change message Notification for az eventhubs namespace application-group policy remove command~~ [EventHub] az eventhubs namespace application-group policy remove: Add upcoming breaking change notification Apr 13, 2023

evelyn-ys merged commit 21fb838 into Azure:dev Apr 13, 2023

Conversation

schaudhari6254888 commented Apr 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

azure-client-tools-bot-prd bot commented Apr 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yonzhan commented Apr 4, 2023

Uh oh!

Uh oh!

schaudhari6254888 commented Apr 10, 2023

Uh oh!

Uh oh!

evelyn-ys commented Apr 11, 2023

Uh oh!

schaudhari6254888 commented Apr 11, 2023

Uh oh!

evelyn-ys commented Apr 11, 2023

Uh oh!

schaudhari6254888 commented Apr 11, 2023

Uh oh!

evelyn-ys commented Apr 11, 2023

Uh oh!

schaudhari6254888 commented Apr 11, 2023

Uh oh!

evelyn-ys Apr 12, 2023

Choose a reason for hiding this comment

Uh oh!

evelyn-ys Apr 12, 2023

Choose a reason for hiding this comment

Uh oh!

schaudhari6254888 Apr 12, 2023

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

schaudhari6254888 commented Apr 4, 2023 •

edited

Loading

azure-client-tools-bot-prd bot commented Apr 4, 2023 •

edited

Loading