{Network} `az network dns record-set`: Migrate commands to codegen v2 by necusjz · Pull Request #26036 · Azure/azure-cli

necusjz · 2023-04-04T04:14:56Z

Related command

Description

Total: 47 commands

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change
[Component Name 2] az command b: Add some customer-facing feature

This checklist is used to make sure that common guidelines for a pull request are followed.

The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.

azure-client-tools-bot-prd · 2023-04-04T04:14:59Z

️✔️acr

️✔️acs

️✔️advisor

️✔️ams

️✔️apim

️✔️appconfig

️✔️appservice

️✔️aro

️✔️backup

️✔️batch

️✔️batchai

️✔️billing

️✔️botservice

️✔️cdn

️✔️cloud

️✔️cognitiveservices

️✔️config

️✔️configure

️✔️consumption

️✔️container

️✔️core

️✔️cosmosdb

️✔️databoxedge

️✔️dla

️✔️dls

️✔️dms

️✔️eventgrid

️✔️eventhubs

️✔️feedback

️✔️find

️✔️hdinsight

️✔️identity

️✔️iot

️✔️keyvault

️✔️kusto

️✔️lab

️✔️managedservices

️✔️maps

️✔️marketplaceordering

️✔️monitor

️✔️netappfiles

️✔️network

️✔️policyinsights

️✔️privatedns

️✔️profile

️✔️rdbms

️✔️redis

️✔️relay

️✔️resource

️✔️role

️✔️search

️✔️security

️✔️servicebus

️✔️serviceconnector

️✔️servicefabric

️✔️signalr

️✔️sql

️✔️sqlvm

️✔️storage

️✔️synapse

️✔️telemetry

️✔️util

️✔️vm

yonzhan · 2023-04-04T04:15:09Z

Network

src/azure-cli/azure/cli/command_modules/network/custom.py

kairu-ms · 2023-04-07T09:25:42Z

src/azure-cli/azure/cli/command_modules/network/custom.py

+        record_set = dict()
+        record_set["ttl"] = ret.get("TTL", None)
+        record_set[record_snake] = ret.get(record_camel, None)
+        record_set = _convert_to_snake_case(record_set)


Why need convert to snack case?

I think AAZCommands can auto parse camel case argument key automatically.

azure-cli/src/azure-cli-core/azure/cli/core/aaz/_field_type.py

Lines 180 to 183 in efc8487

# if key is not found convert camel case key to snack case key

key = to_snack_case(key)

if key in self._fields:

return key

kairu-ms · 2023-04-10T02:52:36Z

src/azure-cli/azure/cli/command_modules/network/custom.py

+def _convert_to_snake_case(element):
+    if isinstance(element, dict):
+        ret = dict()
+        for k, v in element.items():
+            ret[_to_snake(k)] = _convert_to_snake_case(v)
+
+        return ret
+
+    if isinstance(element, list):
+        return [_convert_to_snake_case(i) for i in element]
+
+    return element


What if the element contains property like tags? This will change the key from camel case to snack case.

There is no properties like that, all properties are used for checking:

azure-cli/src/azure-cli/azure/cli/command_modules/network/custom.py

Lines 2985 to 3045 in 478f69c

def _check_a_record_exist(record, exist_list):

for r in exist_list:

if r["ipv4_address"] == record["ipv4_address"]:

return True

return False

def _check_aaaa_record_exist(record, exist_list):

for r in exist_list:

if r["ipv6_address"] == record["ipv6_address"]:

return True

return False

def _check_caa_record_exist(record, exist_list):

for r in exist_list:

if (r["flags"], r["tag"], r["value"]) == (record["flags"], record["tag"], record["value"]):

return True

return False

def _check_cname_record_exist(record, exist_list):

for r in exist_list:

if r["cname"] == record["cname"]:

return True

return False

def _check_mx_record_exist(record, exist_list):

for r in exist_list:

if (r["preference"], r["exchange"]) == (record["preference"], record["exchange"]):

return True

return False

def _check_ns_record_exist(record, exist_list):

for r in exist_list:

if r["nsdname"] == record["nsdname"]:

return True

return False

def _check_ptr_record_exist(record, exist_list):

for r in exist_list:

if r["ptrdname"] == record["ptrdname"]:

return True

return False

def _check_srv_record_exist(record, exist_list):

for r in exist_list:

if (r["priority"], r["weight"], r["port"], r["target"]) == (record["priority"], record["weight"], record["port"], record["target"]):

return True

return False

def _check_txt_record_exist(record, exist_list):

for r in exist_list:

if r["value"] == record["value"]:

return True

return False

…Azure#26036)

necusjz added 5 commits March 27, 2023 15:48

migrate add/create

4d1f449

migrate remove

d7316f9

migrate update

20b09cf

migrate list

93d25f0

revert doc_string_source

b1f11ef

necusjz added this to the April 2023 (2023-04-25) milestone Apr 4, 2023

necusjz self-assigned this Apr 4, 2023

necusjz requested review from jsntcy, kairu-ms and wangzelin007 as code owners April 4, 2023 04:14

ghost requested a review from yonzhan April 4, 2023 04:15

ghost added the Auto-Assign Auto assign by bot label Apr 4, 2023

ghost requested a review from AllyW April 4, 2023 04:15

ghost added the Network az network vnet/lb/nic/dns/etc... label Apr 4, 2023

necusjz added 3 commits April 4, 2023 14:03

fix ci

1702785

fix style/linter

a13bda0

fix ci

77ba82d

kairu-ms reviewed Apr 4, 2023

View reviewed changes

src/azure-cli/azure/cli/command_modules/network/custom.py Show resolved Hide resolved

kairu-ms reviewed Apr 4, 2023

View reviewed changes

src/azure-cli/azure/cli/command_modules/network/custom.py Show resolved Hide resolved

fix ci again

478f69c

kairu-ms reviewed Apr 7, 2023

View reviewed changes

src/azure-cli/azure/cli/command_modules/network/custom.py Show resolved Hide resolved

kairu-ms reviewed Apr 7, 2023

View reviewed changes

kairu-ms reviewed Apr 10, 2023

View reviewed changes

kairu-ms approved these changes Apr 10, 2023

View reviewed changes

necusjz merged commit 3d107c3 into Azure:dev Apr 10, 2023

necusjz deleted the migrate-dns branch April 10, 2023 07:41

avgale pushed a commit to avgale/azure-cli that referenced this pull request Aug 24, 2023

{Network} az network dns record-set: Migrate commands to codegen v2 (…

cfd12c4

…Azure#26036)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

{Network} `az network dns record-set`: Migrate commands to codegen v2#26036

{Network} `az network dns record-set`: Migrate commands to codegen v2#26036
necusjz merged 9 commits intoAzure:devfrom
necusjz:migrate-dns

necusjz commented Apr 4, 2023

Uh oh!

azure-client-tools-bot-prd bot commented Apr 4, 2023 •

edited

Loading

Uh oh!

yonzhan commented Apr 4, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kairu-ms Apr 7, 2023

Uh oh!

kairu-ms Apr 10, 2023

Uh oh!

kairu-ms Apr 10, 2023

Uh oh!

necusjz Apr 10, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	# if key is not found convert camel case key to snack case key
	key = to_snack_case(key)
	if key in self._fields:
	return key

	def _check_a_record_exist(record, exist_list):
	for r in exist_list:
	if r["ipv4_address"] == record["ipv4_address"]:
	return True
	return False


	def _check_aaaa_record_exist(record, exist_list):
	for r in exist_list:
	if r["ipv6_address"] == record["ipv6_address"]:
	return True
	return False


	def _check_caa_record_exist(record, exist_list):
	for r in exist_list:
	if (r["flags"], r["tag"], r["value"]) == (record["flags"], record["tag"], record["value"]):
	return True
	return False


	def _check_cname_record_exist(record, exist_list):
	for r in exist_list:
	if r["cname"] == record["cname"]:
	return True
	return False


	def _check_mx_record_exist(record, exist_list):
	for r in exist_list:
	if (r["preference"], r["exchange"]) == (record["preference"], record["exchange"]):
	return True
	return False


	def _check_ns_record_exist(record, exist_list):
	for r in exist_list:
	if r["nsdname"] == record["nsdname"]:
	return True
	return False


	def _check_ptr_record_exist(record, exist_list):
	for r in exist_list:
	if r["ptrdname"] == record["ptrdname"]:
	return True
	return False


	def _check_srv_record_exist(record, exist_list):
	for r in exist_list:
	if (r["priority"], r["weight"], r["port"], r["target"]) == (record["priority"], record["weight"], record["port"], record["target"]):
	return True
	return False


	def _check_txt_record_exist(record, exist_list):
	for r in exist_list:
	if r["value"] == record["value"]:
	return True
	return False

Conversation

necusjz commented Apr 4, 2023

Uh oh!

azure-client-tools-bot-prd bot commented Apr 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yonzhan commented Apr 4, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kairu-ms Apr 7, 2023

Choose a reason for hiding this comment

Uh oh!

kairu-ms Apr 10, 2023

Choose a reason for hiding this comment

Uh oh!

kairu-ms Apr 10, 2023

Choose a reason for hiding this comment

Uh oh!

necusjz Apr 10, 2023

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

azure-client-tools-bot-prd bot commented Apr 4, 2023 •

edited

Loading