Conversation
️✔️AzureCLI-FullTest
|
Collaborator
|
EventHub |
4d9e64b to
0835ead
Compare
az eventhubs namespace application-group create/delete/list/show/update az eventhubs namespace application-group policy add/remove: Migrating eventhub application-group cmdlets to AAZaz eventhubs namespace application-group create/delete/list/show/update az eventhubs namespace application-group policy add/remove: Migrating eventhub application-group cmdlets to AAZ
kairu-ms
reviewed
May 10, 2023
src/azure-cli/azure/cli/command_modules/eventhubs/Operation/AppgroupCustomFile.py
Outdated
Show resolved
Hide resolved
kairu-ms
reviewed
May 10, 2023
src/azure-cli/azure/cli/command_modules/eventhubs/Operation/AppgroupCustomFile.py
Outdated
Show resolved
Hide resolved
kairu-ms
requested changes
May 10, 2023
Member
|
Hide "--policies" in update command. Customer should not be able to use update to set policies. |
Collaborator
|
Please fix CI issues. |
…into Application-Group
Member
Author
Done |
kairu-ms
reviewed
May 17, 2023
kairu-ms
reviewed
May 17, 2023
kairu-ms
approved these changes
May 17, 2023
avgale
pushed a commit
to avgale/azure-cli
that referenced
this pull request
Aug 24, 2023
…st/show/update` `az eventhubs namespace application-group policy add/remove`: Migrating eventhub application-group cmdlets to AAZ (Azure#26032) * Updates * Updates * Updates76 * Updates77 * fixes and optimization * rename * fixing comments * updates * Update commands.py * recordings * ci's fixes * ci's fixes again * ci's fixes againnn * ci's fixes againnnn * ci's fixesss * Adding correct errrors * Recording * SDK based custom file deleted * cli style error fixed * Updates --------- Co-authored-by: unknown <davadhani@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az eventhubs namespace application-group policy removeDescription
This PR is about Migrating
az eventhubs namespace application-groupcmdlets to AAZ.Also adds the breaking change for
az eventhubs namespace application-group policy removeby removing parameters metric-id, rate-limit-threshold from --throttling-policy-config object.Additionally changing
throttling-policy-configname topolicy, foraz eventhubs namespace application-group policy removecommand.Testing Guide
History Notes
[EventHub] BREAKING CHANGE:
az eventhubs namespace application-group policy remove: Renamed--throttling-policy-configto--policyand removedmetric-idandrate-limit-thresholdproperties in itThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.