Conversation
️✔️acr
️✔️acs
️✔️advisor
️✔️ams
️✔️apim
️✔️appconfig
️✔️appservice
️✔️aro
️✔️backup
️✔️batch
️✔️batchai
️✔️billing
️✔️botservice
️✔️cdn
️✔️cloud
️✔️cognitiveservices
️✔️config
️✔️configure
️✔️consumption
️✔️container
️✔️core
️✔️cosmosdb
️✔️databoxedge
️✔️dla
️✔️dls
️✔️dms
️✔️eventgrid
️✔️eventhubs
️✔️feedback
️✔️find
️✔️hdinsight
️✔️identity
️✔️iot
️✔️keyvault
️✔️kusto
️✔️lab
️✔️managedservices
️✔️maps
️✔️marketplaceordering
️✔️monitor
️✔️netappfiles
️✔️network
️✔️policyinsights
️✔️privatedns
️✔️profile
️✔️rdbms
️✔️redis
️✔️relay
️✔️resource
️✔️role
️✔️search
️✔️security
️✔️servicebus
️✔️serviceconnector
️✔️servicefabric
️✔️signalr
️✔️sql
️✔️sqlvm
️✔️storage
️✔️synapse
️✔️telemetry
️✔️util
️✔️vm
|
|
Hi @schaudhari6254888, |
Collaborator
|
EventHubs |
az eventhubs namespace private-endpoint-connection approve/reject/delete/show/list az eventhubs namespace private-link-resource-show: Migrating eventhubs namespace private-endpoint-connection cmdlets to AAZ.az eventhubs namespace private-endpoint-connection approve/reject/delete/show/list az eventhubs namespace private-link-resource-show: Migrating eventhubs namespace private-endpoint-connection cmdlets to AAZ
Collaborator
|
Please resolve conflicting files. |
…into EH_Private_EndPoint
Member
Author
Resolved. |
evelyn-ys
reviewed
Apr 3, 2023
|
|
||
| # Prepare network | ||
| self.cmd('network vnet create -n {vnet} -g {rg} -l {loc} --subnet-name {subnet}', | ||
| self.cmd('network vnet create -n {vnet} -g test-migration -l {loc} --subnet-name {subnet}', |
Member
There was a problem hiding this comment.
Please don't use fixed resource for test, others can't rerun these tests later
Member
There was a problem hiding this comment.
Have you pushed your changes? What I can see is still using test-migration resource group prepared by yourself in advance
Member
There was a problem hiding this comment.
The @ResourceGroupPreparer decorator has already created tmp resource group with the name starting with cli_test_eh_network for test.
Member
Author
There was a problem hiding this comment.
I see, I was thinking about resources instead of resource-group.
Sorry for the inconvenience. Resolved!
Thank you!
evelyn-ys
approved these changes
Apr 4, 2023
az eventhubs namespace private-endpoint-connection approve/reject/delete/show/list az eventhubs namespace private-link-resource-show: Migrating eventhubs namespace private-endpoint-connection cmdlets to AAZaz eventhubs namespace private-endpoint-connection/private-link-resource: Migrate eventhubs namespace private-endpoint-connection cmdlets to AAZ
avgale
pushed a commit
to avgale/azure-cli
that referenced
this pull request
Aug 24, 2023
…te-link-resource`: Migrate eventhubs namespace private-endpoint-connection cmdlets to AAZ (Azure#25946) * Updates * updates Ci's fixes * ci's fixesssss * Added meaningful description. * updates * Updates * UPdates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
Description
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.