Conversation
|
Eventhub |
…into Auth_Eventhub
|
The CI's are failing due to the below test failed. |
This issue is still open. can someone please help me with this. |
|
To rerun test for hybrid profile, you need to switch env using |
️✔️acr
️✔️acs
️✔️advisor
️✔️ams
️✔️apim
️✔️appconfig
️✔️appservice
️✔️aro
️✔️backup
️✔️batch
️✔️batchai
️✔️billing
️✔️botservice
️✔️cdn
️✔️cloud
️✔️cognitiveservices
️✔️config
️✔️configure
️✔️consumption
️✔️container
️✔️core
️✔️cosmosdb
️✔️databoxedge
️✔️dla
️✔️dls
️✔️dms
️✔️eventgrid
️✔️eventhubs
️✔️feedback
️✔️find
️✔️hdinsight
️✔️identity
️✔️iot
️✔️keyvault
️✔️kusto
️✔️lab
️✔️managedservices
️✔️maps
️✔️marketplaceordering
️✔️monitor
️✔️netappfiles
️✔️network
️✔️policyinsights
️✔️privatedns
️✔️profile
️✔️rdbms
️✔️redis
️✔️relay
️✔️resource
️✔️role
️✔️search
️✔️security
️✔️servicebus
️✔️serviceconnector
️✔️servicefabric
️✔️signalr
️✔️sql
️✔️sqlvm
️✔️storage
️✔️synapse
️✔️telemetry
️✔️util
️✔️vm
|
| self.cmd('iot hub show-connection-string -n {0} --policy-name {1}'.format(hub, policy_name), checks=[ | ||
| self.check_pattern('connectionString', policy_name_conn_str_pattern) | ||
| ]) | ||
| self.cmd('iot hub show-connection-string -n {0} --policy-name {1}'.format(hub, policy_name)) |
There was a problem hiding this comment.
Why you change the test_iot_commands.py file?
There was a problem hiding this comment.
If you want to record the test_iot_hub test for profile 2019-03-01, please checkout to that profile first az cloud set --name AzureCloud --profile 2019-03-01-hybrid and run test in live again.
There was a problem hiding this comment.
Why you want to re-record this test? Is this test related with eventhub module?
There was a problem hiding this comment.
It uses eventhub cmdlet, we are not sure why it is asking for a recording. But, the testcase is buggy from iot hub side and we cannot get it to succeed.
|
|
||
| # Create Cluster | ||
| self.cmd('eventhubs cluster create --resource-group {rg} --name {clustername} --location {loc} --tags tag1=value1', | ||
| self.cmd('eventhubs cluster create --resource-group test-migration --name {clustername} --location eastus --tags tag1=value1', |
There was a problem hiding this comment.
Don't use fixed personal resource group in test
There was a problem hiding this comment.
@evelyn-ys, we will need to do it for this test case because cluster is an expensive resource to create and recently our testscripts created too many clusters that were unmonitored and cost us a lot and hence we decided to use a resource group that we can clean up every day to avoid wastage of resources and money.
There was a problem hiding this comment.
The resource group preparation will do auto clean after test finishing. I don't understand why there will be "too many clusters that were unmonitored". Won't these clusters being deleted during deleting resource group?
There was a problem hiding this comment.
Because Cluster can be deleted only 4 hours after creation.
There was a problem hiding this comment.
Then can you add comments to the test for others who might need to rerun tests after your change to know why and how to prepare for the test
There was a problem hiding this comment.
I have added the comments in cluster test file.
There was a problem hiding this comment.
Can this PR be merged if this comment appears good?
az eventhubs namespace authorization-rule az eventhubs eventhub authorization-rule: Migrating EventHub entity AuthRule and EventHub Namespace AuthRule cmdlets to aaz
az eventhubs namespace authorization-rule az eventhubs eventhub authorization-rule: Migrating EventHub entity AuthRule and EventHub Namespace AuthRule cmdlets to aazaz eventhubs namespace authorization-rule az eventhubs eventhub authorization-rule: Migrating EventHub entity AuthRule and EventHub Namespace AuthRule cmdlets to AAZ
|
|
||
| # Delete Authorization Rule | ||
| self.cmd('eventhubs namespace authorization-rule delete --resource-group {rg} --namespace-name {namespacename} --name {authoname}') | ||
| self.cmd('eventhubs namespace authorization-rule delete --resource-group {rg} --namespace-name {namespacename} --name {authoname} --yes') |
There was a problem hiding this comment.
If this command didn't require --yes for confirmation, then it's breaking change for automation customers because they need to add --yes for their script or else it will hang
There was a problem hiding this comment.
@kairu-ms Is there a way to not add --yes confirmation when using aaz to generate delete command?
There was a problem hiding this comment.
Yes we can remove the confirmation message, to remove --yes when using aaz to generate delete command
az eventhubs namespace authorization-rule az eventhubs eventhub authorization-rule: Migrating EventHub entity AuthRule and EventHub Namespace AuthRule cmdlets to AAZaz eventhubs namespace/eventhub authorization-rule: Migrate EventHub entity AuthRule and EventHub Namespace AuthRule cmdlets to AAZ
…rate EventHub entity AuthRule and EventHub Namespace AuthRule cmdlets to AAZ (Azure#25118) * Eventhub-namespace,Eventhub AuthRule * CI's Fixes * More CI fixes * Updates * CI's fixes * CI fixes * ci agaaaaaaaaaaaaaaaaaaaaaain * CI's fixes again * CI's fixessssssssssssssssssssss * updates * updates * updates * Hybrid profile test_iot_command.py succeeded * Recording added * CI's fixes again * UPdates * UPdates * UPdates * Updates * updatess removed --yes confirmation
Related command
Description
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.