[Network] Convert PublicIP Create to use SDK#2294
Merged
tjprescott merged 2 commits intoAzure:masterfrom Mar 1, 2017
tjprescott:ConvertPublicIp
Merged
[Network] Convert PublicIP Create to use SDK#2294tjprescott merged 2 commits intoAzure:masterfrom tjprescott:ConvertPublicIp
tjprescott merged 2 commits intoAzure:masterfrom
tjprescott:ConvertPublicIp
Conversation
10 tasks
Codecov Report
@@ Coverage Diff @@
## master #2294 +/- ##
==========================================
- Coverage 72.91% 72.84% -0.07%
==========================================
Files 441 425 -16
Lines 19377 19294 -83
Branches 2750 2740 -10
==========================================
- Hits 14129 14055 -74
- Misses 4329 4330 +1
+ Partials 919 909 -10
Continue to review full report at Codecov.
|
yugangw-msft
approved these changes
Feb 28, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#Addresses #2198 for PublicIP.
Breaking Change: Previously this command returned the format:{
"publicIp": { new-public-ip-object }
}
and now it simply returns:
{ new-public-ip-object }
The created object is now wrapped with "publicIp" to avoid a breaking change. It will be removed when the networking API next changes.