[App Service] BREAKING CHANGE: Update websites SDK to the latest version (azure-mgmt-web==2.0.0) & Adopt track2 SDK by panchagnula · Pull Request #17146 · Azure/azure-cli

panchagnula · 2021-02-28T22:12:38Z

Fixes #17228
Fixes #17124
Description
Updating websites extension to latest SDK https://docs.microsoft.com/en-us/python/api/azure-mgmt-web/azure.mgmt.web.v2020_09_01?view=azure-python & this also has the track 2 SDK changes as well.
https://pypi.org/project/azure-mgmt-web/2.0.0/

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.

This checklist is used to make sure that common guidelines for a pull request are followed.

The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.

src/azure-cli/requirements.py3.Darwin.txt

yungezz · 2021-03-01T04:08:48Z

src/azure-cli/requirements.py3.Darwin.txt

[thumb up]!

yungezz · 2021-03-01T08:39:05Z

HI @panchagnula , since this is a major SDK version change from Track1 to Track2, there should be code change also. And run live tests for impacted command modules to avoid regression. thanks.

Track2 migration guide https://github.com/Azure/azure-cli/blob/dev/doc/track_2_migration_guidance.md
cc @qwordy

panchagnula · 2021-03-01T19:37:41Z

HI @panchagnula , since this is a major SDK version change from Track1 to Track2, there should be code change also. And run live tests for impacted command modules to avoid regression. thanks.

Track2 migration guide https://github.com/Azure/azure-cli/blob/dev/doc/track_2_migration_guidance.md
cc @qwordy

yes the PR is marked as draft while i get the tests re-recorded make the necessary fixes.

qwordy · 2021-03-03T08:01:48Z

@panchagnula Could you please summarize the code change pattern when updating to new SDK? Thanks a lot

panchagnula · 2021-03-03T17:53:47Z

@panchagnula Could you please summarize the code change pattern when updating to new SDK? Thanks a lot

@qwordy Sorry, I am not sure what 'code change pattern' are you referring to? Please elaborate or we can discuss offline in email if that helps. Thank you.

qwordy · 2021-03-29T07:25:18Z

@panchagnula Could you please summarize the code change pattern when updating to new SDK? Thanks a lot

@qwordy Sorry, I am not sure what 'code change pattern' are you referring to? Please elaborate or we can discuss offline in email if that helps. Thank you.

@panchagnula This article lists typical modifications when updating to new SDK. Appreciate if you can summarize modifications you made in this PR.
https://github.com/Azure/azure-cli/blob/dev/doc/track_2_migration_guidance.md

qwordy · 2021-03-29T07:28:13Z

@panchagnula This PR isn't active for about one month and is in draft status. Do you encounter any problem? We can provide help.

panchagnula · 2021-03-29T16:01:07Z

@panchagnula This PR isn't active for about one month and is in draft status. Do you encounter any problem? We can provide help.

@qwordy thanks for checking - was heads down on other high pri items - just restarted fixing & re-testing. aim to have this ready out of draft PR by wed this week. Will reach out if I have questions. Thank you.

AnatoliB · 2021-03-29T18:58:11Z

Tagging @gzuber for Functions

panchagnula · 2021-03-31T21:37:34Z

@qwordy can you help me find an owner from bot service - seems like they have their own version of webapp_operations they use & this will be impacted by the new change - so they need fix these on their end.

************* Module azure.cli.command_modules.botservice.bot_json_formatter
src/azure-cli/azure/cli/command_modules/botservice/bot_json_formatter.py:128:40: E1121: Too many positional arguments for constructor call (too-many-function-args)
************* Module azure.cli.command_modules.botservice.web_app_operations
src/azure-cli/azure/cli/command_modules/botservice/web_app_operations.py:70:52: E1121: Too many positional arguments for method call (too-many-function-args)
src/azure-cli/azure/cli/command_modules/botservice/web_app_operations.py:73:16: E1121: Too many positional arguments for method call (too-many-function-args)
src/azure-cli/azure/cli/command_modules/botservice/web_app_operations.py:74:48: E1121: Too many positional arguments for method call (too-many-function-args)

panchagnula · 2021-04-05T22:05:28Z

@qwordy can you review this change & provide feedback as needed. Thank you.

qwordy · 2021-04-07T03:20:51Z

src/azure-cli/azure/cli/command_modules/appservice/_create_util.py

If it is debugging purpose, use logger. If it is command output, consider returning data in a method. Azure CLI will print them. We seldom print data by self.

qwordy · 2021-04-07T03:22:15Z

src/azure-cli/azure/cli/command_modules/appservice/_validators.py

logger is better

Thanks for pointing this out - I had this while I was trying to debug. Will remove this one.

scripts/sdk_process/patch_models.py

Co-authored-by: Feng Zhou <55177366+fengzhou-msft@users.noreply.github.com>

evelyn-ys

Approved for databoxedge part

src/azure-cli/azure/cli/command_modules/appservice/_appservice_utils.py

src/azure-cli/azure/cli/command_modules/appservice/_params.py

panchagnula · 2021-04-13T06:45:15Z

@qwordy can we merge this once the build with the conflicting change merge is successful? Thanks!

…ion (azure-mgmt-web==2.0.0) & Adopt track2 SDK (Azure#17146) * Updating with NewSDK * Adding file to CredScanner * Fixing bot tests * Style checks * Removing unneeded print statements * Update scripts/sdk_process/patch_models.py Co-authored-by: Feng Zhou <55177366+fengzhou-msft@users.noreply.github.com> * removing print statements added for debugging Co-authored-by: Feng Zhou <55177366+fengzhou-msft@users.noreply.github.com>

panchagnula requested review from Juliehzl, evelyn-ys, fengzhou-msft, houk-ms, jiasli and jsntcy as code owners February 28, 2021 22:12

panchagnula marked this pull request as draft February 28, 2021 22:13

panchagnula force-pushed the sisirap-websitesSDK-dev branch from 9ea1ac7 to 4784ee2 Compare February 28, 2021 22:17

yungezz assigned qwordy Mar 1, 2021

yungezz added the App Services az appservice label Mar 1, 2021

yungezz reviewed Mar 1, 2021

View reviewed changes

src/azure-cli/requirements.py3.Darwin.txt Outdated Show resolved Hide resolved

yungezz reviewed Mar 1, 2021

View reviewed changes

src/azure-cli/requirements.py3.Darwin.txt Outdated

Copy link
Copy Markdown

Member

yungezz Mar 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[thumb up]!

panchagnula force-pushed the sisirap-websitesSDK-dev branch from 2aa24ff to a001248 Compare March 2, 2021 04:32

panchagnula force-pushed the sisirap-websitesSDK-dev branch 2 times, most recently from 737636a to 86bd59f Compare March 7, 2021 00:45

panchagnula force-pushed the sisirap-websitesSDK-dev branch from b92887e to a45709c Compare March 29, 2021 18:50

panchagnula force-pushed the sisirap-websitesSDK-dev branch from a45709c to fd28745 Compare March 29, 2021 18:58

panchagnula marked this pull request as ready for review March 31, 2021 20:30

panchagnula requested a review from qwordy as a code owner March 31, 2021 20:30

panchagnula added this to the S185 milestone Mar 31, 2021

panchagnula force-pushed the sisirap-websitesSDK-dev branch from a3777ec to 72f56c4 Compare April 1, 2021 02:02

panchagnula changed the title ~~[App Service]: Updating websites SDK to the latest version (azure-mgmt-web==2.0.0) & Adopt track2 SDK~~ [App Service] BREAKING CHANGE: Updating websites SDK to the latest version (azure-mgmt-web==2.0.0) & Adopt track2 SDK Apr 5, 2021

qwordy reviewed Apr 7, 2021

View reviewed changes

qwordy approved these changes Apr 7, 2021

View reviewed changes

panchagnula added 5 commits April 6, 2021 21:50

Updating with NewSDK

8585f59

Adding file to CredScanner

829762e

Fixing bot tests

afeb4c9

Style checks

f3225df

Removing unneeded print statements

513c763

panchagnula force-pushed the sisirap-websitesSDK-dev branch from f7c1b65 to 513c763 Compare April 7, 2021 05:22

fengzhou-msft changed the title ~~[App Service] BREAKING CHANGE: Updating websites SDK to the latest version (azure-mgmt-web==2.0.0) & Adopt track2 SDK~~ [App Service] BREAKING CHANGE: Update websites SDK to the latest version (azure-mgmt-web==2.0.0) & Adopt track2 SDK Apr 8, 2021

fengzhou-msft reviewed Apr 8, 2021

View reviewed changes

scripts/sdk_process/patch_models.py Outdated Show resolved Hide resolved

Update scripts/sdk_process/patch_models.py

2b401df

Co-authored-by: Feng Zhou <55177366+fengzhou-msft@users.noreply.github.com>

fengzhou-msft approved these changes Apr 8, 2021

View reviewed changes

evelyn-ys approved these changes Apr 8, 2021

View reviewed changes

msyyc approved these changes Apr 8, 2021

View reviewed changes

Juliehzl reviewed Apr 8, 2021

View reviewed changes

src/azure-cli/azure/cli/command_modules/appservice/_appservice_utils.py Outdated Show resolved Hide resolved

Juliehzl reviewed Apr 8, 2021

View reviewed changes

src/azure-cli/azure/cli/command_modules/appservice/_params.py Show resolved Hide resolved

kairu-ms approved these changes Apr 8, 2021

View reviewed changes

removing print statements added for debugging

5a63def

qwordy modified the milestones: S185, S186 Apr 9, 2021

Juliehzl approved these changes Apr 9, 2021

View reviewed changes

Merge branch 'dev' into sisirap-websitesSDK-dev

94030e0

qwordy merged commit 680f833 into Azure:dev Apr 14, 2021

panchagnula mentioned this pull request Apr 15, 2021

{App Service} Fixing errors from new SDK update & updated recordings #17717

Merged

3 tasks

WibblyDibbler mentioned this pull request May 19, 2021

az cli "hybrid connections not supported on linux app." #17124

Closed

Conversation

panchagnula commented Feb 28, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

yungezz Mar 1, 2021

Choose a reason for hiding this comment

Uh oh!

yungezz commented Mar 1, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

panchagnula commented Mar 1, 2021

Uh oh!

qwordy commented Mar 3, 2021

Uh oh!

panchagnula commented Mar 3, 2021

Uh oh!

qwordy commented Mar 29, 2021

Uh oh!

qwordy commented Mar 29, 2021

Uh oh!

panchagnula commented Mar 29, 2021

Uh oh!

AnatoliB commented Mar 29, 2021

Uh oh!

panchagnula commented Mar 31, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

panchagnula commented Apr 5, 2021

Uh oh!

qwordy Apr 7, 2021

Choose a reason for hiding this comment

Uh oh!

qwordy Apr 7, 2021

Choose a reason for hiding this comment

Uh oh!

panchagnula Apr 7, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

evelyn-ys left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

panchagnula commented Apr 13, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

panchagnula commented Feb 28, 2021 •

edited

Loading

yungezz commented Mar 1, 2021 •

edited

Loading

panchagnula commented Mar 31, 2021 •

edited

Loading